From: Jason Gunthorpe <jgg-uk2M96/98Pc@public.gmane.org>
To: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Parav Pandit <parav-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
Bart Van Assche <Bart.VanAssche-Sjgp3cTcYWE@public.gmane.org>,
"linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH rdma-core] mlx4: Fix 1<<31 expressions
Date: Fri, 9 Feb 2018 09:51:38 -0700 [thread overview]
Message-ID: <20180209165138.GA11850@ziepe.ca> (raw)
In-Reply-To: <20180209164200.GO2197-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
On Fri, Feb 09, 2018 at 06:42:00PM +0200, Leon Romanovsky wrote:
> On Fri, Feb 09, 2018 at 09:13:25AM -0700, Jason Gunthorpe wrote:
> > On Fri, Feb 09, 2018 at 04:12:24PM +0000, Parav Pandit wrote:
> >
> > > > I did a patch that will make our public headers mostly strictly conforming to C11
> > > > with -Wpedantic set, which I've been wondering if it is worth sending..
> >
> > > Any reason to use open code instead of using BIT() macro from
> > > include/linux/bitops.h which does the same thing?
> >
> > BIT only works in the kernel. This is a publich header from rdma-core
> > userspace.
>
> ➜ rdma-core git:(master) git grep "define BIT" providers/mlx5/cq.c
> providers/mlx5/cq.c:#define BIT(i) (1UL << (i))
Still can't use it in a public header.
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-02-09 16:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-08 23:38 [PATCH rdma-core] mlx4: Fix 1<<31 expressions Jason Gunthorpe
[not found] ` <20180208233829.GA16128-uk2M96/98Pc@public.gmane.org>
2018-02-09 16:01 ` Bart Van Assche
[not found] ` <1518192109.2871.5.camel-Sjgp3cTcYWE@public.gmane.org>
2018-02-09 16:10 ` Jason Gunthorpe
[not found] ` <20180209161030.GA7584-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2018-02-09 16:12 ` Parav Pandit
[not found] ` <HE1PR0502MB3004BB45FC9ADB9B49CAF283D1F20-692Kmc8YnlL9PhveBwpv4cDSnupUy6xnnBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org>
2018-02-09 16:13 ` Jason Gunthorpe
[not found] ` <20180209161325.GD7570-uk2M96/98Pc@public.gmane.org>
2018-02-09 16:20 ` Parav Pandit
2018-02-09 16:42 ` Leon Romanovsky
[not found] ` <20180209164200.GO2197-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2018-02-09 16:51 ` Jason Gunthorpe [this message]
[not found] ` <20180209165138.GA11850-uk2M96/98Pc@public.gmane.org>
2018-02-09 16:55 ` Leon Romanovsky
2018-02-09 16:19 ` Bart Van Assche
[not found] ` <1518193161.2871.14.camel-Sjgp3cTcYWE@public.gmane.org>
2018-02-09 16:24 ` Jason Gunthorpe
[not found] ` <20180209162453.GD7584-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2018-02-09 17:18 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180209165138.GA11850@ziepe.ca \
--to=jgg-uk2m96/98pc@public.gmane.org \
--cc=Bart.VanAssche-Sjgp3cTcYWE@public.gmane.org \
--cc=leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=parav-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).