public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgg-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
To: Adit Ranadive <aditr-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org>
Cc: dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
	leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Aditya Sarwade <asarwade-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org>,
	stable-Xl5UnYtxxKxKUA01WzcqbQ@public.gmane.org
Subject: Re: [PATCH rdma-core] vmw_pvrdma: Fix SRQN returned to library
Date: Mon, 12 Feb 2018 15:26:50 -0700	[thread overview]
Message-ID: <20180212222650.GA10773@mellanox.com> (raw)
In-Reply-To: <ab90a493-3680-d776-e52b-3918b2bd1a6a-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org>

On Mon, Feb 12, 2018 at 02:23:18PM -0800, Adit Ranadive wrote:

> > I can't make sense of this.
> > 
> > Why doesn't grep turn up anything for struct pvrdma_create_srq_resp in
> > the kernel?
> 
> Do you mean user_pvrdma_create_srq_resp? There isn’t one.

No, I mean what I wrote..

include/uapi/rdma/vmw_pvrdma-abi.h:struct pvrdma_create_srq_resp {

Why isn't it used anywhere?

> > And why do we have two things called srqn in this struct?
> 
> It looks like the uverbs in the kernel reports the XRC SRQN in the one of
> these while the other gets populated by the driver in the udata here. The SRQN
> for a regular SRQ only gets reported in this second srqn field.
> I'm not sure why that's the case but we need to report the one from the
> driver here then.

Ok

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2018-02-12 22:26 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-12 18:42 [PATCH rdma-core] vmw_pvrdma: Fix SRQN returned to library Adit Ranadive
     [not found] ` <1518460956-4629-1-git-send-email-aditr-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org>
2018-02-12 18:59   ` Jason Gunthorpe
     [not found]     ` <20180212185906.GE5005-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2018-02-12 22:23       ` Adit Ranadive
     [not found]         ` <ab90a493-3680-d776-e52b-3918b2bd1a6a-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org>
2018-02-12 22:26           ` Jason Gunthorpe [this message]
     [not found]             ` <20180212222650.GA10773-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2018-02-12 23:19               ` Adit Ranadive
2018-02-13 12:24   ` Nicolas Morey-Chaisemartin
     [not found]     ` <de50c35a-731d-bfb6-efe9-7f2ad83ea7b3-l3A5Bk7waGM@public.gmane.org>
2018-02-13 14:10       ` Llolsten Kaonga
2018-02-13 18:43       ` Adit Ranadive
2018-02-14  6:12       ` Adit Ranadive
     [not found]         ` <8b4f73e6-af5c-d5e2-5425-fbd706a50f66-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org>
2018-02-14  7:59           ` Nicolas Morey-Chaisemartin
     [not found]             ` <b5512350-48f1-c4e6-096f-a44307bdf015-l3A5Bk7waGM@public.gmane.org>
2018-02-14  8:29               ` Adit Ranadive
2018-02-16  0:47               ` Adit Ranadive

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180212222650.GA10773@mellanox.com \
    --to=jgg-vpraknaxozvwk0htik3j/w@public.gmane.org \
    --cc=aditr-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org \
    --cc=asarwade-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org \
    --cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=stable-Xl5UnYtxxKxKUA01WzcqbQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox