From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH rdma-core] vmw_pvrdma: Fix SRQN returned to library Date: Mon, 12 Feb 2018 15:26:50 -0700 Message-ID: <20180212222650.GA10773@mellanox.com> References: <1518460956-4629-1-git-send-email-aditr@vmware.com> <20180212185906.GE5005@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Adit Ranadive Cc: dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Aditya Sarwade , stable-Xl5UnYtxxKxKUA01WzcqbQ@public.gmane.org List-Id: linux-rdma@vger.kernel.org On Mon, Feb 12, 2018 at 02:23:18PM -0800, Adit Ranadive wrote: > > I can't make sense of this. > > > > Why doesn't grep turn up anything for struct pvrdma_create_srq_resp in > > the kernel? > > Do you mean user_pvrdma_create_srq_resp? There isn’t one. No, I mean what I wrote.. include/uapi/rdma/vmw_pvrdma-abi.h:struct pvrdma_create_srq_resp { Why isn't it used anywhere? > > And why do we have two things called srqn in this struct? > > It looks like the uverbs in the kernel reports the XRC SRQN in the one of > these while the other gets populated by the driver in the udata here. The SRQN > for a regular SRQ only gets reported in this second srqn field. > I'm not sure why that's the case but we need to report the one from the > driver here then. Ok Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html