Re: [PATCHv2 1/1] IB/rxe: remove unnecessary skb_clone

Yonatan Cohen
2018-02-18T08:12:27Z

On 2/14/2018 12:36 PM, Yuval Shaia wrote:
>>>> }
>>>> - skb_copy = skb_clone(skb, GFP_ATOMIC);
>>>> - if (skb_copy)
>>>> - rxe_add_ref(qp); /* for the new SKB */
>>> Are you sure we don't need this?
>> From my stress tests and performance tests, it will get better performance
>> to remove skb_clone.
>
> My concern is only with the above ref count.
I agree with yuval in case xmit fails.
send_atomic_ack()
{
rxe_xmit_packet()
{
rxe_send()
{
rxe_add_ref(pkt->qp) <--- add qp ref
err = ip_local_out() <---- fail here
}

if (rxe_xmit_packet() fails) {
rxe_drop_ref(qp) <--- you must deref here
}
}
>
>> And there is no memory leak.  The whole soft RoCE can work well.
>> So I think removing this function is a good choice.
>>
>> Zhu Yanjun
>>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html