Re: [PATCHv2 1/1] IB/rxe: remove unnecessary skb_clone

Yuval Shaia
2018-02-14T10:36:30Z

> > > }
> > > - skb_copy = skb_clone(skb, GFP_ATOMIC);
> > > - if (skb_copy)
> > > - rxe_add_ref(qp); /* for the new SKB */
> > Are you sure we don't need this?
> From my stress tests and performance tests, it will get better performance
> to remove skb_clone.

My concern is only with the above ref count.

> And there is no memory leak.  The whole soft RoCE can work well.
> So I think removing this function is a good choice.
>
> Zhu Yanjun
> >