From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yuval Shaia Subject: Re: [PATCHv2 1/1] IB/rxe: remove unnecessary skb_clone Date: Wed, 14 Feb 2018 12:36:30 +0200 Message-ID: <20180214103630.GB4282@yuvallap> References: <1515140391-24752-1-git-send-email-yanjun.zhu@oracle.com> <1518508786-3204-1-git-send-email-yanjun.zhu@oracle.com> <20180213112124.GA6991@yuvallap> <5779a11b-d0f2-3231-a63f-009b1f080fb8@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: <5779a11b-d0f2-3231-a63f-009b1f080fb8-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Yanjun Zhu Cc: monis-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org, dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, jgg-uk2M96/98Pc@public.gmane.org, linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-rdma@vger.kernel.org > > > } > > > - skb_copy = skb_clone(skb, GFP_ATOMIC); > > > - if (skb_copy) > > > - rxe_add_ref(qp); /* for the new SKB */ > > Are you sure we don't need this? > From my stress tests and performance tests, it will get better performance > to remove skb_clone. My concern is only with the above ref count. > And there is no memory leak.  The whole soft RoCE can work well. > So I think removing this function is a good choice. > > Zhu Yanjun > > -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html