From: Jason Gunthorpe <jgg-uk2M96/98Pc@public.gmane.org>
To: Steve Wise <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
Cc: dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH rdma-rc] RDMA/restrack: don't use uaccess_kernel()
Date: Thu, 15 Feb 2018 15:41:17 -0700 [thread overview]
Message-ID: <20180215224117.GA7803@ziepe.ca> (raw)
In-Reply-To: <02a301d3a6a8$e3b5dee0$ab219ca0$@opengridcomputing.com>
On Thu, Feb 15, 2018 at 04:04:02PM -0600, Steve Wise wrote:
> >
> > On Thu, Feb 08, 2018 at 12:09:43PM -0800, Steve Wise wrote:
> > > + case RDMA_RESTRACK_QP:
> > > + qp = container_of(res, struct ib_qp, res);
> > > + if (qp->pd)
> > > + is_user = qp->pd->uobject;
> >
> > ?? Why is this like this?
> >
> > struct ib_qp has a uboject, why do we need to look at the PD?
>
> I wasn't getting the correct user/kernel setting when I used qp->uobject.
> Perhaps I should revisit this.
Oh that answer certainly makes me nervous.. Let's explain that please
and either change it or add a big fat comment here about why it has to
be like this.
Thanks,
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-02-15 22:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-08 20:09 [PATCH rdma-rc] RDMA/restrack: don't use uaccess_kernel() Steve Wise
[not found] ` <eac01039be8c0518e37928e5b003a911c32e53a7.1518468700.git.swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
2018-02-13 9:01 ` Leon Romanovsky
[not found] ` <20180213090122.GT2197-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2018-02-13 15:10 ` Steve Wise
2018-02-15 21:58 ` Jason Gunthorpe
[not found] ` <20180215215854.GA16973-uk2M96/98Pc@public.gmane.org>
2018-02-15 22:04 ` Steve Wise
2018-02-15 22:41 ` Jason Gunthorpe [this message]
[not found] ` <20180215224117.GA7803-uk2M96/98Pc@public.gmane.org>
2018-02-16 15:47 ` Steve Wise
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180215224117.GA7803@ziepe.ca \
--to=jgg-uk2m96/98pc@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).