From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leon Romanovsky Subject: Re: [PATCH for-rc 4/6] RDMA/bnxt_re: Synchronize destroy_qp with poll_cq Date: Fri, 16 Feb 2018 09:38:02 +0200 Message-ID: <20180216073802.GM2197@mtr-leonro.local> References: <1518758413-20850-1-git-send-email-selvin.xavier@broadcom.com> <1518758413-20850-5-git-send-email-selvin.xavier@broadcom.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="i/VKSWANvDZSIhsB" Return-path: Content-Disposition: inline In-Reply-To: <1518758413-20850-5-git-send-email-selvin.xavier-dY08KVG/lbpWk0Htik3J/w@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Selvin Xavier Cc: dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, jgg-uk2M96/98Pc@public.gmane.org, linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-rdma@vger.kernel.org --i/VKSWANvDZSIhsB Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Feb 15, 2018 at 09:20:11PM -0800, Selvin Xavier wrote: > Avoid system crash when destroy_qp is invoked while > the driver is processing the poll_cq. Synchronize these > functions using the cq_lock. > > Signed-off-by: Selvin Xavier > --- > drivers/infiniband/hw/bnxt_re/ib_verbs.c | 39 +++++++++++++++++++++++++++++--- > drivers/infiniband/hw/bnxt_re/ib_verbs.h | 2 ++ > drivers/infiniband/hw/bnxt_re/qplib_fp.c | 21 +++++------------ > drivers/infiniband/hw/bnxt_re/qplib_fp.h | 4 +++- > 4 files changed, 47 insertions(+), 19 deletions(-) > > diff --git a/drivers/infiniband/hw/bnxt_re/ib_verbs.c b/drivers/infiniband/hw/bnxt_re/ib_verbs.c > index b7eb104..9cb9928 100644 > --- a/drivers/infiniband/hw/bnxt_re/ib_verbs.c > +++ b/drivers/infiniband/hw/bnxt_re/ib_verbs.c > @@ -786,20 +786,51 @@ int bnxt_re_query_ah(struct ib_ah *ib_ah, struct rdma_ah_attr *ah_attr) > return 0; > } > > +static unsigned long bnxt_re_lock_cqs(struct bnxt_re_qp *qp) > + __acquires(&qp->scq->cq_lock) __acquires(&qp->rcq->cq_lock) > +{ > + unsigned long flags; > + > + spin_lock_irqsave(&qp->scq->cq_lock, flags); > + if (qp->rcq != qp->scq) > + spin_lock(&qp->rcq->cq_lock); > + else > + __acquire(&qp->rcq->cq_lock); Sorry for naive question, why do you need __acquire/__release? And why can't spin_is_locked(&qp->rcq->cq_lock) be used for unlock code? > + > + return flags; > +} > + > +static void bnxt_re_unlock_cqs(struct bnxt_re_qp *qp, > + unsigned long flags) > + __releases(&qp->scq->cq_lock) __releases(&qp->rcq->cq_lock) > +{ > + if (qp->rcq != qp->scq) > + spin_unlock(&qp->rcq->cq_lock); > + else > + __release(&qp->rcq->cq_lock); > + spin_unlock_irqrestore(&qp->scq->cq_lock, flags); > +} > + Thanks --i/VKSWANvDZSIhsB Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEkhr/r4Op1/04yqaB5GN7iDZyWKcFAlqGiloACgkQ5GN7iDZy WKdDww//Vha+OrSUM5uX+kTSv7tvXeIjCRbxSK0rAW462uAk7+rt20ZfY315s1XT kuubDk+kOCcMM47MlyG4M/7MpgBzaRcSLOxozQnu3L7qRXMjbiy4A8y5pcknBt7c d/s7ha31OJrBQO2wFMddiKteEIaJU84aNOAN6eyRvQ69d5jDrAur9u7YLhY99Rjn 7UlWXSQTDc0+VCasRVXlqwOUpsTWgm58pw9gaT/qHdbW0HJwVBHu/VcpkMUlUQBF UHb56g8iHwRdSjXTW3R2I5EEyv/j13LyrFB/5NRAGhQ9c+U9sGPcH1NjL5nk4vEJ 9AO+bW2fVGtO7xmZFBbDnn3TvDuGJN/GBh5S9bT+LyGj5SEnkpPjlZZBwkcAinQ0 pHSWR/k3E0hc+s6YFoGVpsk/zqM3ErT6S2gNg1t+VXSvn/ZCaKiZyHg/Wylygl+I oPUJQrtBf/wR2N19IN8C96pVnFou/Zz4iTQjkrzlK6C2HOO4Naq8JUrEuj4necic 5a+OKn8L+sSzfYiWb3m4MdwH1DvdP1h3sGnDLbi3S9l1mgw4GugPCem1WZhA6zOe YuEmdPvCladfswwzs/S2+9g08DGhTeZUYL6rwzmrDqQbWXur5NxRnQxzhQYc8eSr aaXvlCjD4y1OFArtgCsPof5by1Ye1MBXsiz9gKrI9hZPhz281wM= =kYvX -----END PGP SIGNATURE----- --i/VKSWANvDZSIhsB-- -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html