From: Jason Gunthorpe <jgg@ziepe.ca>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: Max Gurtovoy <maxg@mellanox.com>,
Chuck Lever <chuck.lever@oracle.com>,
Bart Van Assche <Bart.VanAssche@wdc.com>,
"arnd@arndb.de" <arnd@arndb.de>,
"dledford@redhat.com" <dledford@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"leonro@mellanox.com" <leonro@mellanox.com>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>
Subject: Re: [PATCH] RDMA/core: reduce IB_POLL_BATCH constant
Date: Tue, 27 Feb 2018 15:09:58 -0700 [thread overview]
Message-ID: <20180227220958.GA21714@ziepe.ca> (raw)
In-Reply-To: <c1bcd5cc-381d-2d94-1278-f9fb5c9c0b14@grimberg.me>
On Thu, Feb 22, 2018 at 05:39:09PM +0200, Sagi Grimberg wrote:
>
> >>The only reason why I added this array on-stack was to allow consumers
> >>that did not use ib_alloc_cq api to call it, but that seems like a
> >>wrong decision when thinking it over again (as probably these users
> >>did not set the wr_cqe correctly).
> >>
> >>How about we make ib_process_cq_direct use the cq wc array and add
> >>a WARN_ON statement (and fail it gracefully) if the caller used this
> >>API without calling ib_alloc_cq?
> >
> >but we tried to avoid cuncurrent access to cq->wc.
>
> Not sure its a valid use-case. But if there is a compelling
> reason to keep it as is, then we can do smaller on-stack
> array.
Did we come to a conclusion what to do here?
Jason
next parent reply other threads:[~2018-02-27 22:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180220205924.2035765-1-arnd@arndb.de>
[not found] ` <1519161268.3737.12.camel@wdc.com>
[not found] ` <F2FB1034-BFB6-45ED-878E-6FADD756157D@oracle.com>
[not found] ` <c3eab137-1c37-0e6c-a53a-df2cf80653d2@grimberg.me>
[not found] ` <0f90134c-3d40-1d24-711f-e4ab32802bd8@mellanox.com>
[not found] ` <c1bcd5cc-381d-2d94-1278-f9fb5c9c0b14@grimberg.me>
2018-02-27 22:09 ` Jason Gunthorpe [this message]
2018-02-27 22:15 ` [PATCH] RDMA/core: reduce IB_POLL_BATCH constant Max Gurtovoy
2018-02-28 0:21 ` Bart Van Assche
2018-02-28 9:50 ` Max Gurtovoy
2018-02-28 18:55 ` Doug Ledford
2018-03-01 9:36 ` Max Gurtovoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180227220958.GA21714@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=Bart.VanAssche@wdc.com \
--cc=arnd@arndb.de \
--cc=chuck.lever@oracle.com \
--cc=dledford@redhat.com \
--cc=leonro@mellanox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=maxg@mellanox.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox