From: Jason Gunthorpe <jgg@ziepe.ca>
To: Steve Wise <swise@opengridcomputing.com>
Cc: 'Bart Van Assche' <bart.vanassche@wdc.com>,
'Doug Ledford' <dledford@redhat.com>,
'Laurence Oberman' <loberman@redhat.com>,
linux-rdma@vger.kernel.org, 'Sagi Grimberg' <sagi@grimberg.me>,
stable@vger.kernel.org
Subject: Re: [PATCH 1/3] RDMA/core: Avoid that ib_drain_qp() triggers an out-of-bounds stack access
Date: Thu, 1 Mar 2018 15:46:47 -0700 [thread overview]
Message-ID: <20180301224647.GM19007@ziepe.ca> (raw)
In-Reply-To: <002f01d3b1ab$e4926640$adb732c0$@opengridcomputing.com>
On Thu, Mar 01, 2018 at 04:23:15PM -0600, Steve Wise wrote:
> > I don't get it..
> >
> > Since when did ib_post_send() start requiring a ib_rdma_wr?
> >
> > IB_WR_RDMA_WRITE == 0, so even missing that is 'OK' but ugly.
> >
> > What is the actual bug here?
> >
>
> The WRs are now split up, so struct ib_send_wr doesn't encompass the full
> size of all the possible WRs. See ib_rdma_wr, for example, which includes
> ib_send_wr. So the bug is the drain code is posting a WRITE wr, but not
> including the entire struct ib_rdma_wr.
Oh.. yes, I forgot about that patch. Thanks, OK.
Jason
next prev parent reply other threads:[~2018-03-01 22:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180301220030.27433-1-bart.vanassche@wdc.com>
2018-03-01 22:00 ` [PATCH 1/3] RDMA/core: Avoid that ib_drain_qp() triggers an out-of-bounds stack access Bart Van Assche
2018-03-01 22:19 ` Jason Gunthorpe
2018-03-01 22:23 ` Steve Wise
2018-03-01 22:46 ` Jason Gunthorpe [this message]
2018-03-01 22:00 ` [PATCH 2/3] RDMA/rxe: Fix an out-of-bounds read Bart Van Assche
2018-03-01 22:00 ` [PATCH 3/3] IB/srpt: Fix an out-of-bounds stack access in srpt_zerolength_write() Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180301224647.GM19007@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=bart.vanassche@wdc.com \
--cc=dledford@redhat.com \
--cc=linux-rdma@vger.kernel.org \
--cc=loberman@redhat.com \
--cc=sagi@grimberg.me \
--cc=stable@vger.kernel.org \
--cc=swise@opengridcomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox