* [PATCH v2] infiniband: hw: Drop unnecessary continue
@ 2018-03-03 16:24 Arushi Singhal
2018-03-06 23:35 ` Jason Gunthorpe
0 siblings, 1 reply; 2+ messages in thread
From: Arushi Singhal @ 2018-03-03 16:24 UTC (permalink / raw)
To: dennis.dalessandro
Cc: Mike Marciniszyn, Doug Ledford, Jason Gunthorpe, linux-rdma,
linux-kernel, outreachy-kernel
Continue at the bottom of a loop are removed.
Issue found using drop_continue.cocci Coccinelle script.
Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
---
Changes in v2:
- Braces is dropped from if with single statement.
drivers/infiniband/hw/qib/qib_init.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/infiniband/hw/qib/qib_init.c b/drivers/infiniband/hw/qib/qib_init.c
index 3990f38..6c68f8a 100644
--- a/drivers/infiniband/hw/qib/qib_init.c
+++ b/drivers/infiniband/hw/qib/qib_init.c
@@ -678,11 +678,9 @@ int qib_init(struct qib_devdata *dd, int reinit)
lastfail = qib_create_rcvhdrq(dd, rcd);
if (!lastfail)
lastfail = qib_setup_eagerbufs(rcd);
- if (lastfail) {
+ if (lastfail)
qib_dev_err(dd,
"failed to allocate kernel ctxt's rcvhdrq and/or egr bufs\n");
- continue;
- }
}
for (pidx = 0; pidx < dd->num_pports; ++pidx) {
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] infiniband: hw: Drop unnecessary continue
2018-03-03 16:24 [PATCH v2] infiniband: hw: Drop unnecessary continue Arushi Singhal
@ 2018-03-06 23:35 ` Jason Gunthorpe
0 siblings, 0 replies; 2+ messages in thread
From: Jason Gunthorpe @ 2018-03-06 23:35 UTC (permalink / raw)
To: Arushi
Cc: dennis.dalessandro, Mike Marciniszyn, Doug Ledford, linux-rdma,
linux-kernel, outreachy-kernel
On Sat, Mar 03, 2018 at 09:54:57PM +0530, Arushi wrote:
> Continue at the bottom of a loop are removed.
> Issue found using drop_continue.cocci Coccinelle script.
>
> Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
> Changes in v2:
> - Braces is dropped from if with single statement.
>
> drivers/infiniband/hw/qib/qib_init.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
applied to for-next
Thanks
Jason
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-03-06 23:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-03-03 16:24 [PATCH v2] infiniband: hw: Drop unnecessary continue Arushi Singhal
2018-03-06 23:35 ` Jason Gunthorpe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).