* [linux-next:master 6181/6533] net/rds/message.c:336:5: sparse: symbol 'rds_message_zcopy_from_user' was not declared. Should it be static?
@ 2018-03-08 10:56 kbuild test robot
2018-03-08 10:56 ` [RFC PATCH linux-next] rds: rds_message_zcopy_from_user() can be static kbuild test robot
0 siblings, 1 reply; 2+ messages in thread
From: kbuild test robot @ 2018-03-08 10:56 UTC (permalink / raw)
To: Sowmini Varadhan
Cc: kbuild-all, Santosh Shilimkar, netdev, linux-rdma, rds-devel,
linux-kernel
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: c6f1a8c953479b390458e36fb838d96199a5f466
commit: d40a126b16ea851f858f97b0e214d97c8355cecb [6181/6533] rds: refactor zcopy code into rds_message_zcopy_from_user
reproduce:
# apt-get install sparse
git checkout d40a126b16ea851f858f97b0e214d97c8355cecb
make ARCH=x86_64 allmodconfig
make C=1 CF=-D__CHECK_ENDIAN__
sparse warnings: (new ones prefixed by >>)
>> net/rds/message.c:336:5: sparse: symbol 'rds_message_zcopy_from_user' was not declared. Should it be static?
Please review and possibly fold the followup patch.
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
^ permalink raw reply [flat|nested] 2+ messages in thread
* [RFC PATCH linux-next] rds: rds_message_zcopy_from_user() can be static
2018-03-08 10:56 [linux-next:master 6181/6533] net/rds/message.c:336:5: sparse: symbol 'rds_message_zcopy_from_user' was not declared. Should it be static? kbuild test robot
@ 2018-03-08 10:56 ` kbuild test robot
0 siblings, 0 replies; 2+ messages in thread
From: kbuild test robot @ 2018-03-08 10:56 UTC (permalink / raw)
To: Sowmini Varadhan
Cc: kbuild-all, Santosh Shilimkar, netdev, linux-rdma, rds-devel,
linux-kernel
Fixes: d40a126b16ea ("rds: refactor zcopy code into rds_message_zcopy_from_user")
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
message.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/rds/message.c b/net/rds/message.c
index c36edbb9..6d87910b 100644
--- a/net/rds/message.c
+++ b/net/rds/message.c
@@ -333,7 +333,7 @@ struct rds_message *rds_message_map_pages(unsigned long *page_addrs, unsigned in
return rm;
}
-int rds_message_zcopy_from_user(struct rds_message *rm, struct iov_iter *from)
+static int rds_message_zcopy_from_user(struct rds_message *rm, struct iov_iter *from)
{
unsigned long sg_off;
struct scatterlist *sg;
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-03-08 10:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-03-08 10:56 [linux-next:master 6181/6533] net/rds/message.c:336:5: sparse: symbol 'rds_message_zcopy_from_user' was not declared. Should it be static? kbuild test robot
2018-03-08 10:56 ` [RFC PATCH linux-next] rds: rds_message_zcopy_from_user() can be static kbuild test robot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).