* [PATCH] IB/mlx5: Set the default active rate and width to QDR and 4X
@ 2018-03-16 2:37 Honggang LI
2018-03-16 14:59 ` Hal Rosenstock
2018-03-19 17:53 ` Jason Gunthorpe
0 siblings, 2 replies; 4+ messages in thread
From: Honggang LI @ 2018-03-16 2:37 UTC (permalink / raw)
To: dledford, jgg, matanb, leonro, linux-rdma; +Cc: linux-kernel, noaos, honli
From: Honggang Li <honli@redhat.com>
commit f1b65df5a232 ("IB/mlx5: Add support for active_width and
active_speed in RoCE"). Before this patch applied, the mlx5_ib
driver set default active_width and active_speed to IB_WIDTH_4X
and IB_SPEED_QDR.
When the RoCE port is down, the RoCE port did not negotiate the
active width with remote side. The active width is zero. If run
ibstat to require the port status, ibstat will panic as it read
invalid width from sys file.
This patch restores the original behavior.
Fixes: f1b65df5a232 ("IB/mlx5: Add support for active_width and active_speed in RoCE").
Signed-off-by: Honggang Li <honli@redhat.com>
---
drivers/infiniband/hw/mlx5/main.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/infiniband/hw/mlx5/main.c b/drivers/infiniband/hw/mlx5/main.c
index 033b6af90de9..a48e9730fab8 100644
--- a/drivers/infiniband/hw/mlx5/main.c
+++ b/drivers/infiniband/hw/mlx5/main.c
@@ -388,6 +388,9 @@ static int mlx5_query_port_roce(struct ib_device *device, u8 port_num,
if (err)
goto out;
+ props->active_width = IB_WIDTH_4X;
+ props->active_speed = IB_SPEED_QDR;
+
translate_eth_proto_oper(eth_prot_oper, &props->active_speed,
&props->active_width);
--
2.14.GIT
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] IB/mlx5: Set the default active rate and width to QDR and 4X
2018-03-16 2:37 [PATCH] IB/mlx5: Set the default active rate and width to QDR and 4X Honggang LI
@ 2018-03-16 14:59 ` Hal Rosenstock
2018-03-18 7:28 ` Noa Osherovich
2018-03-19 17:53 ` Jason Gunthorpe
1 sibling, 1 reply; 4+ messages in thread
From: Hal Rosenstock @ 2018-03-16 14:59 UTC (permalink / raw)
To: Honggang LI, dledford, jgg, matanb, leonro, linux-rdma
Cc: linux-kernel, noaos
On 3/15/2018 10:37 PM, Honggang LI wrote:
> From: Honggang Li <honli@redhat.com>
>
> commit f1b65df5a232 ("IB/mlx5: Add support for active_width and
> active_speed in RoCE"). Before this patch applied, the mlx5_ib
> driver set default active_width and active_speed to IB_WIDTH_4X
> and IB_SPEED_QDR.
>
> When the RoCE port is down, the RoCE port did not negotiate the
> active width with remote side. The active width is zero. If run
> ibstat to require the port status, ibstat will panic as it read
> invalid width from sys file.
>
> This patch restores the original behavior.
>
> Fixes: f1b65df5a232 ("IB/mlx5: Add support for active_width and active_speed in RoCE").
> Signed-off-by: Honggang Li <honli@redhat.com>
Reviewed-by: Hal Rosenstock <hal@mellanox.com>
> ---
> drivers/infiniband/hw/mlx5/main.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/infiniband/hw/mlx5/main.c b/drivers/infiniband/hw/mlx5/main.c
> index 033b6af90de9..a48e9730fab8 100644
> --- a/drivers/infiniband/hw/mlx5/main.c
> +++ b/drivers/infiniband/hw/mlx5/main.c
> @@ -388,6 +388,9 @@ static int mlx5_query_port_roce(struct ib_device *device, u8 port_num,
> if (err)
> goto out;
>
> + props->active_width = IB_WIDTH_4X;
> + props->active_speed = IB_SPEED_QDR;
> +
> translate_eth_proto_oper(eth_prot_oper, &props->active_speed,
> &props->active_width);
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] IB/mlx5: Set the default active rate and width to QDR and 4X
2018-03-16 14:59 ` Hal Rosenstock
@ 2018-03-18 7:28 ` Noa Osherovich
0 siblings, 0 replies; 4+ messages in thread
From: Noa Osherovich @ 2018-03-18 7:28 UTC (permalink / raw)
To: Hal Rosenstock, Honggang LI, dledford, jgg, matanb, leonro,
linux-rdma
Cc: linux-kernel
On 3/16/2018 4:59 PM, Hal Rosenstock wrote:
> On 3/15/2018 10:37 PM, Honggang LI wrote:
>> From: Honggang Li <honli@redhat.com>
>>
>> commit f1b65df5a232 ("IB/mlx5: Add support for active_width and
>> active_speed in RoCE"). Before this patch applied, the mlx5_ib
>> driver set default active_width and active_speed to IB_WIDTH_4X
>> and IB_SPEED_QDR.
>>
>> When the RoCE port is down, the RoCE port did not negotiate the
>> active width with remote side. The active width is zero. If run
>> ibstat to require the port status, ibstat will panic as it read
>> invalid width from sys file.
>>
>> This patch restores the original behavior.
>>
>> Fixes: f1b65df5a232 ("IB/mlx5: Add support for active_width and active_speed in RoCE").
>> Signed-off-by: Honggang Li <honli@redhat.com>
> Reviewed-by: Hal Rosenstock <hal@mellanox.com>
Reviewed-by: Noa Osherovich <noaos@mellanox.com>
>
>> ---
>> drivers/infiniband/hw/mlx5/main.c | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/infiniband/hw/mlx5/main.c b/drivers/infiniband/hw/mlx5/main.c
>> index 033b6af90de9..a48e9730fab8 100644
>> --- a/drivers/infiniband/hw/mlx5/main.c
>> +++ b/drivers/infiniband/hw/mlx5/main.c
>> @@ -388,6 +388,9 @@ static int mlx5_query_port_roce(struct ib_device *device, u8 port_num,
>> if (err)
>> goto out;
>>
>> + props->active_width = IB_WIDTH_4X;
>> + props->active_speed = IB_SPEED_QDR;
>> +
>> translate_eth_proto_oper(eth_prot_oper, &props->active_speed,
>> &props->active_width);
>>
>>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] IB/mlx5: Set the default active rate and width to QDR and 4X
2018-03-16 2:37 [PATCH] IB/mlx5: Set the default active rate and width to QDR and 4X Honggang LI
2018-03-16 14:59 ` Hal Rosenstock
@ 2018-03-19 17:53 ` Jason Gunthorpe
1 sibling, 0 replies; 4+ messages in thread
From: Jason Gunthorpe @ 2018-03-19 17:53 UTC (permalink / raw)
To: Honggang LI; +Cc: dledford, matanb, leonro, linux-rdma, linux-kernel, noaos
On Fri, Mar 16, 2018 at 10:37:13AM +0800, Honggang LI wrote:
> From: Honggang Li <honli@redhat.com>
>
> commit f1b65df5a232 ("IB/mlx5: Add support for active_width and
> active_speed in RoCE"). Before this patch applied, the mlx5_ib
> driver set default active_width and active_speed to IB_WIDTH_4X
> and IB_SPEED_QDR.
>
> When the RoCE port is down, the RoCE port did not negotiate the
> active width with remote side. The active width is zero. If run
> ibstat to require the port status, ibstat will panic as it read
> invalid width from sys file.
>
> This patch restores the original behavior.
>
> Fixes: f1b65df5a232 ("IB/mlx5: Add support for active_width and active_speed in RoCE").
> Signed-off-by: Honggang Li <honli@redhat.com>
> Reviewed-by: Hal Rosenstock <hal@mellanox.com>
> Reviewed-by: Noa Osherovich <noaos@mellanox.com>
> drivers/infiniband/hw/mlx5/main.c | 3 +++
> 1 file changed, 3 insertions(+)
Applied to for-next, thanks
Jason
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-03-19 17:53 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-03-16 2:37 [PATCH] IB/mlx5: Set the default active rate and width to QDR and 4X Honggang LI
2018-03-16 14:59 ` Hal Rosenstock
2018-03-18 7:28 ` Noa Osherovich
2018-03-19 17:53 ` Jason Gunthorpe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).