From: Leon Romanovsky <leon@kernel.org>
To: Steve Wise <swise@opengridcomputing.com>
Cc: David Ahern <dsahern@gmail.com>,
stephen@networkplumber.org, netdev@vger.kernel.org,
linux-rdma@vger.kernel.org
Subject: Re: [PATCH v2 iproute2-next 3/6] rdma: Add CM_ID resource tracking information
Date: Mon, 26 Mar 2018 18:08:26 +0300 [thread overview]
Message-ID: <20180326150826.GH1877@mtr-leonro.local> (raw)
In-Reply-To: <783e600a-9296-8ea0-003e-59e48fd5234b@opengridcomputing.com>
[-- Attachment #1: Type: text/plain, Size: 1116 bytes --]
On Mon, Mar 26, 2018 at 09:55:46AM -0500, Steve Wise wrote:
>
>
> On 3/26/2018 9:44 AM, David Ahern wrote:
> > On 3/26/18 8:30 AM, Steve Wise wrote:
> >>
> >> On 3/26/2018 9:17 AM, David Ahern wrote:
> >>> On 2/27/18 9:07 AM, Steve Wise wrote:
> >>>> diff --git a/rdma/rdma.h b/rdma/rdma.h
> >>>> index 5809f70..e55205b 100644
> >>>> --- a/rdma/rdma.h
> >>>> +++ b/rdma/rdma.h
> >>>> @@ -18,10 +18,12 @@
> >>>> #include <libmnl/libmnl.h>
> >>>> #include <rdma/rdma_netlink.h>
> >>>> #include <time.h>
> >>>> +#include <net/if_arp.h>
> >>>>
> >>>> #include "list.h"
> >>>> #include "utils.h"
> >>>> #include "json_writer.h"
> >>>> +#include <rdma/rdma_cma.h>
> >>>>
> >>> did you forget to add rdma_cma.h? I don't see that file in my repo.
> >> It is provided by the rdma-core package, upon which rdma tool now
> >> depends for the rdma_port_space enum.
> >>
> > You need to add a check for the package, and only build rdma if that
> > package is installed. See check_mnl in configure for an example.
>
> Ok, that makes sense.
IMHO, better solution will be to copy those files to iproute2.
Thanks
>
> Steve.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-03-26 15:08 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1520020530.git.swise@opengridcomputing.com>
[not found] ` <743dc7a5306f9b3368fcd4c143cdd822250444a6.1520020530.git.swise@opengridcomputing.com>
2018-03-26 14:17 ` [PATCH v2 iproute2-next 3/6] rdma: Add CM_ID resource tracking information David Ahern
2018-03-26 14:30 ` Steve Wise
2018-03-26 14:44 ` David Ahern
2018-03-26 14:55 ` Steve Wise
2018-03-26 15:08 ` Leon Romanovsky [this message]
2018-03-26 15:24 ` Steve Wise
2018-03-26 17:06 ` Leon Romanovsky
2018-03-26 17:13 ` Steve Wise
2018-03-26 17:27 ` Leon Romanovsky
2018-03-26 21:15 ` Jason Gunthorpe
2018-03-26 21:34 ` Steve Wise
2018-03-26 22:30 ` Jason Gunthorpe
2018-03-27 3:21 ` Leon Romanovsky
2018-03-27 14:44 ` Jason Gunthorpe
2018-03-27 15:15 ` Leon Romanovsky
2018-03-27 15:23 ` Jason Gunthorpe
2018-03-27 15:45 ` Steve Wise
2018-03-27 16:01 ` Leon Romanovsky
2018-03-27 16:20 ` Steve Wise
2018-03-27 16:30 ` Leon Romanovsky
2018-03-27 16:38 ` Steve Wise
2018-03-26 15:40 ` David Ahern
2018-03-26 19:55 ` Steve Wise
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180326150826.GH1877@mtr-leonro.local \
--to=leon@kernel.org \
--cc=dsahern@gmail.com \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
--cc=swise@opengridcomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).