linux-rdma.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgg-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
To: Jonathan Cameron
	<Jonathan.Cameron-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
Cc: "Jens Axboe" <axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org>,
	linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	"Alex Williamson"
	<alex.williamson-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org,
	linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	"Sinan Kaya" <okaya-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
	"Jérôme Glisse" <jglisse-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	"Benjamin Herrenschmidt"
	<benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>,
	"Bjorn Helgaas"
	<bhelgaas-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
	"Max Gurtovoy" <maxg-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
	"Keith Busch"
	<keith.busch-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	"Eric Wehage"
	<Eric.Wehage-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>,
	"Christoph Hellwig" <hch-jcswGhMUV9g@public.gmane.org>
Subject: Re: [PATCH v3 01/11] PCI/P2PDMA: Support peer-to-peer memory
Date: Mon, 26 Mar 2018 10:41:29 -0600	[thread overview]
Message-ID: <20180326164129.GF15530@mellanox.com> (raw)
In-Reply-To: <20180326121138.00005e30-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>

On Mon, Mar 26, 2018 at 12:11:38PM +0100, Jonathan Cameron wrote:
> On Tue, 13 Mar 2018 10:43:55 -0600
> Logan Gunthorpe <logang-OTvnGxWRz7hWk0Htik3J/w@public.gmane.org> wrote:
> 
> > On 12/03/18 09:28 PM, Sinan Kaya wrote:
> > > On 3/12/2018 3:35 PM, Logan Gunthorpe wrote:
> > > Regarding the switch business, It is amazing how much trouble you went into
> > > limit this functionality into very specific hardware.
> > > 
> > > I thought that we reached to an agreement that code would not impose
> > > any limits on what user wants.
> > > 
> > > What happened to all the emails we exchanged?  
> > 
> > It turns out that root ports that support P2P are far less common than 
> > anyone thought. So it will likely have to be a white list.
> 
> This came as a bit of a surprise to our PCIe architect.

I don't think it is a hardware problem.

I know Mellanox and Nvidia have been doing p2p on Intel root complexes
for something like 5-6 years now.. I don't have the details, but it
does seem to work.

I have heard some chips give poor performance..

Also AMD GPU SLI uses P2P these days, so this isn't exactly a niche
feature in Intel/AMD land.

I think the main issue here is that there is some BIOS involvement to
set things up properly. Eg in GPU land motherboards certify for
'crossfire' support.

> His follow up was whether it was worth raising an ECR for the PCIe spec
> to add a capability bit to allow this to be discovered.  This might
> long term avoid the need to maintain the white list for new devices.

If it is primarily a BIOS issue then it should be an ACPI thing, right?

Jason

  parent reply	other threads:[~2018-03-26 16:41 UTC|newest]

Thread overview: 68+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-12 19:35 [PATCH v3 00/11] Copy Offload in NVMe Fabrics with P2P PCI Memory Logan Gunthorpe
2018-03-12 19:35 ` [PATCH v3 01/11] PCI/P2PDMA: Support peer-to-peer memory Logan Gunthorpe
     [not found]   ` <20180312193525.2855-2-logang-OTvnGxWRz7hWk0Htik3J/w@public.gmane.org>
2018-03-13  3:28     ` Sinan Kaya
     [not found]       ` <59fd2f5d-177f-334a-a9c4-0f8a6ec7c303-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2018-03-13 16:43         ` Logan Gunthorpe
     [not found]           ` <24d8e5c2-065d-8bde-3f5d-7f158be9c578-OTvnGxWRz7hWk0Htik3J/w@public.gmane.org>
2018-03-13 17:49             ` Sinan Kaya
     [not found]               ` <52cbbbc4-c488-f83f-8d02-14d455b4efd7-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2018-03-13 18:44                 ` Logan Gunthorpe
     [not found]                   ` <3e738f95-d73c-4182-2fa1-8664aafb1ab7-OTvnGxWRz7hWk0Htik3J/w@public.gmane.org>
2018-03-13 19:10                     ` Sinan Kaya
     [not found]                       ` <703aa92c-0c1c-4852-5887-6f6e6ccde0fb-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2018-03-13 19:19                         ` Logan Gunthorpe
     [not found]                           ` <a0af83f8-2cbc-862b-6f8b-231991527cfc-OTvnGxWRz7hWk0Htik3J/w@public.gmane.org>
2018-03-13 19:53                             ` Sinan Kaya
     [not found]                               ` <3ea80992-a0fc-08f2-d93d-ae0ec4e3f4ce-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2018-03-13 20:46                                 ` Logan Gunthorpe
     [not found]                                   ` <4eb6850c-df1b-fd44-3ee0-d43a50270b53-OTvnGxWRz7hWk0Htik3J/w@public.gmane.org>
2018-03-13 21:22                                     ` Sinan Kaya
     [not found]                                       ` <757fca36-dee4-e070-669e-f2788bd78e41-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2018-03-13 22:00                                         ` Logan Gunthorpe
     [not found]                                           ` <4f761f55-4e9a-dccb-d12f-c59d2cd689db-OTvnGxWRz7hWk0Htik3J/w@public.gmane.org>
2018-03-13 22:29                                             ` Sinan Kaya
2018-03-13 22:45                                               ` Stephen  Bates
     [not found]                                               ` <016dc910-f96a-8a60-4bda-fa24eea98ea5-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2018-03-13 22:48                                                 ` Logan Gunthorpe
     [not found]                                                   ` <2b152932-2f44-408b-e3ed-b4608d95f82e-OTvnGxWRz7hWk0Htik3J/w@public.gmane.org>
2018-03-13 23:19                                                     ` Sinan Kaya
     [not found]                                                       ` <156c24fb-6e27-28f6-0b36-7fd83311ce37-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2018-03-13 23:45                                                         ` Logan Gunthorpe
     [not found]                                                           ` <932bbf48-9d86-97ec-17bb-052099aff99e-OTvnGxWRz7hWk0Htik3J/w@public.gmane.org>
2018-03-14 12:16                                                             ` David Laight
     [not found]                                                               ` <6e36d43b0493455a8547bc50c8ec77ba-1XygrNkDbNvwg4NCKwmqgw@public.gmane.org>
2018-03-14 16:23                                                                 ` Logan Gunthorpe
2018-03-13 22:31                                             ` Stephen  Bates
     [not found]                                               ` <BB94077B-7EB3-49C4-862D-BF77D0A692CC-pv7U853sEMVWk0Htik3J/w@public.gmane.org>
2018-03-13 23:08                                                 ` Bjorn Helgaas
     [not found]                                                   ` <20180313230850.GA45763-1RhO1Y9PlrlHTL0Zs8A6p5iNqAH0jzoTYJqu5kTmcBRl57MIdRCFDg@public.gmane.org>
2018-03-13 23:21                                                     ` Logan Gunthorpe
2018-03-14  2:56                                                       ` Bjorn Helgaas
     [not found]                                                         ` <20180314025639.GA50067-1RhO1Y9PlrlHTL0Zs8A6p5iNqAH0jzoTYJqu5kTmcBRl57MIdRCFDg@public.gmane.org>
2018-03-14 14:05                                                           ` Stephen  Bates
2018-03-14 16:17                                                           ` Logan Gunthorpe
     [not found]                                                             ` <112493af-ccd0-455b-6600-b50764f7ab7e-OTvnGxWRz7hWk0Htik3J/w@public.gmane.org>
2018-03-14 18:51                                                               ` Bjorn Helgaas
     [not found]                                                                 ` <20180314185159.GD179719-1RhO1Y9PlrlHTL0Zs8A6p5iNqAH0jzoTYJqu5kTmcBRl57MIdRCFDg@public.gmane.org>
2018-03-14 19:03                                                                   ` Logan Gunthorpe
     [not found]                                                                     ` <b75e83ad-bb83-1f8d-1751-0989cc2493f1-OTvnGxWRz7hWk0Htik3J/w@public.gmane.org>
2018-03-14 19:28                                                                       ` Dan Williams
     [not found]                                                                         ` <CAPcyv4g-A6fqdTahxX=aONSCgp1eEvBb=ZVMzbZUWUDmqBbj7Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-03-14 19:30                                                                           ` Logan Gunthorpe
2018-03-14 19:34                                                                           ` Stephen  Bates
     [not found]                                                                             ` <AA646409-BB63-4757-A250-CE7118D4D3B8-pv7U853sEMVWk0Htik3J/w@public.gmane.org>
2018-03-15  4:00                                                                               ` Martin K. Petersen
2018-03-15  4:30                                                                               ` Dan Williams
2018-03-22 22:57                                                     ` Stephen  Bates
     [not found]                                                       ` <C90AA66C-FFC6-4CCA-B959-7BBECA65509C-pv7U853sEMVWk0Htik3J/w@public.gmane.org>
2018-03-23 21:50                                                         ` Bjorn Helgaas
     [not found]                                                           ` <20180323215046.GC210003-1RhO1Y9PlrlHTL0Zs8A6p5iNqAH0jzoTYJqu5kTmcBRl57MIdRCFDg@public.gmane.org>
2018-03-23 21:59                                                             ` Logan Gunthorpe
     [not found]                                                               ` <dc414fa5-1af9-0ba7-e12e-4cd9df313119-OTvnGxWRz7hWk0Htik3J/w@public.gmane.org>
2018-03-24  3:49                                                                 ` Bjorn Helgaas
     [not found]                                                                   ` <20180324034947.GE210003-1RhO1Y9PlrlHTL0Zs8A6p5iNqAH0jzoTYJqu5kTmcBRl57MIdRCFDg@public.gmane.org>
2018-03-24 15:28                                                                     ` Stephen  Bates
     [not found]                                                                       ` <121026DC-40C7-4F4E-BE27-BDA652BDEB6A-pv7U853sEMVWk0Htik3J/w@public.gmane.org>
2018-03-26 15:43                                                                         ` Logan Gunthorpe
2018-03-26 11:11           ` Jonathan Cameron
     [not found]             ` <20180326121138.00005e30-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2018-03-26 14:01               ` Bjorn Helgaas
     [not found]                 ` <20180326140118.GA221690-1RhO1Y9PlrlHTL0Zs8A6p5iNqAH0jzoTYJqu5kTmcBRl57MIdRCFDg@public.gmane.org>
2018-03-26 15:46                   ` Logan Gunthorpe
     [not found]                     ` <c717eb06-1e83-f0f3-4d6c-15531aa808e0-OTvnGxWRz7hWk0Htik3J/w@public.gmane.org>
2018-03-27  8:47                       ` Jonathan Cameron
     [not found]                         ` <20180327094701.0000300d-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2018-03-27 15:37                           ` Logan Gunthorpe
2018-04-13 21:56                           ` Stephen  Bates
2018-03-26 16:41               ` Jason Gunthorpe [this message]
     [not found]                 ` <20180326164129.GF15530-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2018-03-26 17:30                   ` Logan Gunthorpe
     [not found]                     ` <6ead7f19-c0e5-5584-2518-1e1889a007e4-OTvnGxWRz7hWk0Htik3J/w@public.gmane.org>
2018-03-26 19:35                       ` Jason Gunthorpe
     [not found]                         ` <20180326193502.GI15530-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2018-03-26 20:42                           ` Logan Gunthorpe
2018-03-13 18:40         ` Logan Gunthorpe
     [not found] ` <20180312193525.2855-1-logang-OTvnGxWRz7hWk0Htik3J/w@public.gmane.org>
2018-03-12 19:35   ` [PATCH v3 02/11] PCI/P2PDMA: Add sysfs group to display p2pmem stats Logan Gunthorpe
2018-03-12 19:35   ` [PATCH v3 03/11] PCI/P2PDMA: Add PCI p2pmem dma mappings to adjust the bus offset Logan Gunthorpe
2018-03-12 19:35   ` [PATCH v3 04/11] PCI/P2PDMA: Clear ACS P2P flags for all devices behind switches Logan Gunthorpe
2018-03-12 19:35   ` [PATCH v3 05/11] PCI/P2PDMA: Add P2P DMA driver writer's documentation Logan Gunthorpe
     [not found]     ` <20180312193525.2855-6-logang-OTvnGxWRz7hWk0Htik3J/w@public.gmane.org>
2018-03-12 19:41       ` Jonathan Corbet
     [not found]         ` <20180312134114.1e4b12f8-T1hC0tSOHrs@public.gmane.org>
2018-03-12 21:18           ` Logan Gunthorpe
2018-03-12 19:35   ` [PATCH v3 06/11] block: Introduce PCI P2P flags for request and request queue Logan Gunthorpe
     [not found]     ` <20180312193525.2855-7-logang-OTvnGxWRz7hWk0Htik3J/w@public.gmane.org>
2018-03-21  9:27       ` Christoph Hellwig
2018-03-12 19:35   ` [PATCH v3 07/11] IB/core: Ensure we map P2P memory correctly in rdma_rw_ctx_[init|destroy]() Logan Gunthorpe
     [not found]     ` <20180312193525.2855-8-logang-OTvnGxWRz7hWk0Htik3J/w@public.gmane.org>
2018-03-21  9:27       ` Christoph Hellwig
2018-03-12 19:35   ` [PATCH v3 08/11] nvme-pci: Use PCI p2pmem subsystem to manage the CMB Logan Gunthorpe
     [not found]     ` <20180312193525.2855-9-logang-OTvnGxWRz7hWk0Htik3J/w@public.gmane.org>
2018-03-13  1:55       ` Sinan Kaya
     [not found]         ` <4b08ec0b-76f4-4b67-a38b-5a1940c4c40d-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2018-03-13  1:58           ` Sinan Kaya
2018-03-12 19:35   ` [PATCH v3 09/11] nvme-pci: Add support for P2P memory in requests Logan Gunthorpe
     [not found]     ` <20180312193525.2855-10-logang-OTvnGxWRz7hWk0Htik3J/w@public.gmane.org>
2018-03-21  9:23       ` Christoph Hellwig
2018-03-12 19:35   ` [PATCH v3 10/11] nvme-pci: Add a quirk for a pseudo CMB Logan Gunthorpe
2018-03-12 19:35   ` [PATCH v3 11/11] nvmet: Optionally use PCI P2P memory Logan Gunthorpe
     [not found]     ` <20180312193525.2855-12-logang-OTvnGxWRz7hWk0Htik3J/w@public.gmane.org>
2018-03-21  9:27       ` Christoph Hellwig
     [not found]         ` <20180321092702.GC7098-jcswGhMUV9g@public.gmane.org>
2018-03-21 16:52           ` Logan Gunthorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180326164129.GF15530@mellanox.com \
    --to=jgg-vpraknaxozvwk0htik3j/w@public.gmane.org \
    --cc=Eric.Wehage-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
    --cc=Jonathan.Cameron-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
    --cc=alex.williamson-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org \
    --cc=benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org \
    --cc=bhelgaas-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
    --cc=hch-jcswGhMUV9g@public.gmane.org \
    --cc=jglisse-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=keith.busch-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org \
    --cc=linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=maxg-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    --cc=okaya-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).