From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leon Romanovsky Subject: Re: [PATCH v2 iproute2-next 3/6] rdma: Add CM_ID resource tracking information Date: Tue, 27 Mar 2018 06:21:41 +0300 Message-ID: <20180327032141.GS1877@mtr-leonro.local> References: <743dc7a5306f9b3368fcd4c143cdd822250444a6.1520020530.git.swise@opengridcomputing.com> <0443b8e0-17ff-1e62-51ba-ba1fa0e0d529@opengridcomputing.com> <20180326211505.GF15554@ziepe.ca> <20180326223033.GK15554@ziepe.ca> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="4OpS+d6oOtUQaRm1" Return-path: Content-Disposition: inline In-Reply-To: <20180326223033.GK15554@ziepe.ca> Sender: netdev-owner@vger.kernel.org To: Jason Gunthorpe Cc: Steve Wise , David Ahern , stephen@networkplumber.org, netdev@vger.kernel.org, linux-rdma@vger.kernel.org List-Id: linux-rdma@vger.kernel.org --4OpS+d6oOtUQaRm1 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Mar 26, 2018 at 04:30:33PM -0600, Jason Gunthorpe wrote: > On Mon, Mar 26, 2018 at 04:34:44PM -0500, Steve Wise wrote: > > > > On 3/26/2018 4:15 PM, Jason Gunthorpe wrote: > > > On Mon, Mar 26, 2018 at 09:30:41AM -0500, Steve Wise wrote: > > >> > > >> On 3/26/2018 9:17 AM, David Ahern wrote: > > >>> On 2/27/18 9:07 AM, Steve Wise wrote: > > >>>> diff --git a/rdma/rdma.h b/rdma/rdma.h > > >>>> index 5809f70..e55205b 100644 > > >>>> +++ b/rdma/rdma.h > > >>>> @@ -18,10 +18,12 @@ > > >>>> #include > > >>>> #include > > >>>> #include > > >>>> +#include > > >>>> > > >>>> #include "list.h" > > >>>> #include "utils.h" > > >>>> #include "json_writer.h" > > >>>> +#include > > >>>> > > >>> did you forget to add rdma_cma.h? I don't see that file in my repo. > > >> It is provided by the rdma-core package, upon which rdma tool now > > >> depends for the rdma_port_space enum. > > > It is a kernel bug that enum is not in an include/uapi/rdma header > > > > > > Fix it there and don't try to use rdma-core headers to get kernel ABI. > > > > > > Jason > > > > I wish you'd commented on this just a little sooner.=A0 I just resent v3 > > of this series... with rdma_cma.h included. :) > > > > How about the restrack/nldev code just translates the port space from > > enum rdma_port_space to a new ABI enum, say nldev_rdma_port_space, that > > i add to rdma_netlink.h?=A0 I'd hate to open the can of worms of trying= to > > split rdma_cma.h into uabi and no uabi headers. :( > > If port space is already part of the ABI there isn't much reason to > translate it. > > You just need to pick the right header to put it in, since it is a verbs > define it doesn't belong in the netlink header. I completely understand Steve's concerns. I tried to do such thing (expose kernel headers) in first incarnation of rdmatool with attempt to clean IB/core as well to ensure that we won't expo= se anything that is not implemented. It didn't go well. Thanks > > Jason --4OpS+d6oOtUQaRm1 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEkhr/r4Op1/04yqaB5GN7iDZyWKcFAlq5uMUACgkQ5GN7iDZy WKeq0w/7BcsPU63wt30+HplHa19ufjzi+6esj5EEQxrPwyUqoDgmiH0Cwxfq9FOM l8KNBHYRZvKqF0BBeUBoPDF664+O+G27+gf9/SyYqwFImbiI4pwaFf/kn858y14g /sMf3JNLCeVtWBUG1r/I2k+nj602pShgvtGlbCTXIMRKHOTVbTANcSN6Aj1ooTNC 9XJSP3+4BOgTBcdYvQ3A1Zm2nqv7ua3RAF5qumLvlGw+ObuXSeFsScK9d/Wh9JJl 6jodx7KbNnLPJqSIJKCtJbWbvoDQvykuvcOSARK8MLDlChYmHgp600JUt/qNTAxS XRq5zHMomkMroMbBdxayHgC8U+icIQ23l4+L5AKGILVUbhiJupHnsJdXMKHc1V/V GCZX2uDo3kAqI5hnKQGR/2QomqGBA5uTAeyYTQeOp5gP0JYQsLYklMKgr22ANHoe ddVC0BVMuS9fv2kzbAS+W7bX/pnJcvx6Gqf6Ze45vR3/jFn+XDO7XwOPaZz36BWk JSX48BTu/lz6usSaf0f4OjtCPx4GJeTih6JyD/ZtpqfBINPYoIAuwc2bnpPaZ36V ajvPhNVAMOp6sH2/rboetHPDMJZrb9WPXznqmkjPX2azQUZ3lqgrLn8vh+wcYlpR BAhxTLeCIBSIuNu8CsRiEz/31hCoowX5i98D1as47u8O6NVJ8qA= =ijf1 -----END PGP SIGNATURE----- --4OpS+d6oOtUQaRm1--