Re: [PATCH v4 00/14] Copy Offload in NVMe Fabrics with P2P PCI Memory

Logan Gunthorpe
2018-05-04T15:52:26Z

On 04/05/18 08:27 AM, Christian König wrote:
> Are you sure that this is more convenient? At least on first glance it
> feels overly complicated.
>
> I mean what's the difference between the two approaches?
>
>     sum = pci_p2pdma_distance(target, [A, B, C, target]);
>
> and
>
>     sum = pci_p2pdma_distance(target, A);
>     sum += pci_p2pdma_distance(target, B);
>     sum += pci_p2pdma_distance(target, C);

Well, it's more for consistency with the pci_p2pdma_find() which has to
take a list of devices to find a resource which matches all of them.
(You can't use multiple calls in that case because all the devices in
the list might not have the same set of compatible providers.) That way
we can use the same list to check the distance (when the user specifies
a device) as we do to find a compatible device (when the user wants to
automatically find one.

Logan
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org