From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH] iw_cxgb4: add INFINIBAND_ADDR_TRANS dependency Date: Thu, 7 Jun 2018 12:00:34 -0600 Message-ID: <20180607180034.GD14583@ziepe.ca> References: <20180530220405.GH30754@ziepe.ca> <0be4e0fb-8d8e-b337-fc8d-550c90829d8c@opengridcomputing.com> <20180530222520.GJ30754@ziepe.ca> <20180530230136.GK30754@ziepe.ca> <20180604230745.GG24926@ziepe.ca> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Greg Thelen Cc: Doug Ledford , Arnd Bergmann , swise@opengridcomputing.com, swise@chelsio.com, yuval.shaia@oracle.com, linux-rdma@vger.kernel.org, LKML , Tarick Bedeir List-Id: linux-rdma@vger.kernel.org On Thu, Jun 07, 2018 at 01:10:39AM -0700, Greg Thelen wrote: > > > I don't really think I like this approach though. At a minimum if you > > > are going to make iWARP totally dependent on rdmacm, then there is zero > > > reason that iw_cm.o should be part of the obj-$(CONFIG_INFINIBAND) > > > Makefile recipe when ADDR_TRANS is disabled. > > > > This makes sense, Greg, can you send a followup patch with these > > items? I know this series has been tough.. > > > > Thanks, > > Jason > > Ack. Sorry for delay. I'll take a look at this in a day or two. Let > me know if it's more urgent. No rush, sometime in the next several weeks is fine Jason