Linux RDMA and InfiniBand development
 help / color / mirror / Atom feed
From: Qing Huang <qing.huang@oracle.com>
To: linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
Cc: jgg@ziepe.ca, dledford@redhat.com, leon@kernel.org,
	gerald.gibson@oracle.com, qing.huang@oracle.com
Subject: [PATCH] IB/mlx5: avoid binding a new mpi unit to the same devices repeatedly
Date: Fri, 13 Jul 2018 16:50:21 -0700	[thread overview]
Message-ID: <20180713235021.18141-1-qing.huang@oracle.com> (raw)

When a CX5 device is configured in dual-port RoCE mode, after creating
many VFs against port 1, creating the same number of VFs against port 2
will flood kernel/syslog with something like
"mlx5_*:mlx5_ib_bind_slave_port:4266:(pid 5269): port 2 already
affiliated."

So basically, when traversing mlx5_ib_dev_list, mlx5_ib_add_slave_port()
shouldn't repeatedly attempt to bind the new mpi data unit to every device
on the list until it finds an unbound device.

Reported-by: Gerald Gibson <gerald.gibson@oracle.com>
Signed-off-by: Qing Huang <qing.huang@oracle.com>
---
 drivers/infiniband/hw/mlx5/main.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/infiniband/hw/mlx5/main.c b/drivers/infiniband/hw/mlx5/main.c
index b3ba9a2..1ddd1d3 100644
--- a/drivers/infiniband/hw/mlx5/main.c
+++ b/drivers/infiniband/hw/mlx5/main.c
@@ -6068,7 +6068,8 @@ static void *mlx5_ib_add_slave_port(struct mlx5_core_dev *mdev, u8 port_num)
 
 	mutex_lock(&mlx5_ib_multiport_mutex);
 	list_for_each_entry(dev, &mlx5_ib_dev_list, ib_dev_list) {
-		if (dev->sys_image_guid == mpi->sys_image_guid)
+		if (dev->sys_image_guid == mpi->sys_image_guid &&
+		    !dev->port[mlx5_core_native_port_num(mdev) - 1].mp.mpi)
 			bound = mlx5_ib_bind_slave_port(dev, mpi);
 
 		if (bound) {
-- 
2.9.3

             reply	other threads:[~2018-07-13 23:50 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-13 23:50 Qing Huang [this message]
2018-07-14 15:57 ` [PATCH] IB/mlx5: avoid binding a new mpi unit to the same devices repeatedly Or Gerlitz
2018-07-15  6:04   ` Leon Romanovsky
2018-07-15 19:48   ` Daniel Jurgens
2018-07-23 15:36     ` Qing Huang
2018-07-23 16:21       ` Parav Pandit
2018-07-23 18:11       ` Daniel Jurgens
2018-07-23 18:21         ` Qing Huang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180713235021.18141-1-qing.huang@oracle.com \
    --to=qing.huang@oracle.com \
    --cc=dledford@redhat.com \
    --cc=gerald.gibson@oracle.com \
    --cc=jgg@ziepe.ca \
    --cc=leon@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox