[PATCH] drivers: infiniband: core: Remove extra parentheses

[PATCH] drivers: infiniband: core: Remove extra parentheses

[Varsha Rao]

Remove unnecessary parentheses to fix the clang warning of extraneous
parentheses.

Signed-off-by: Varsha Rao <rvarsha016@gmail.com>
---
 drivers/infiniband/core/cma.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/infiniband/core/cma.c b/drivers/infiniband/core/cma.c
index bff10ab141b0..c200a2e748f0 100644
--- a/drivers/infiniband/core/cma.c
+++ b/drivers/infiniband/core/cma.c
@@ -4010,7 +4010,7 @@ static void cma_set_mgid(struct rdma_id_private *id_priv,
 		memcpy(mgid, &sin6->sin6_addr, sizeof *mgid);
 	} else if (addr->sa_family == AF_IB) {
 		memcpy(mgid, &((struct sockaddr_ib *) addr)->sib_addr, sizeof *mgid);
-	} else if ((addr->sa_family == AF_INET6)) {
+	} else if (addr->sa_family == AF_INET6) {
 		ipv6_ib_mc_map(&sin6->sin6_addr, dev_addr->broadcast, mc_map);
 		if (id_priv->id.ps == RDMA_PS_UDP)
 			mc_map[7] = 0x01;	/* Use RDMA CM signature */
-- 
2.17.0

Re: [PATCH] drivers: infiniband: core: Remove extra parentheses

[Jason Gunthorpe]

On Wed, Jul 25, 2018 at 08:43:56PM +0200, Varsha Rao wrote:
> Remove unnecessary parentheses to fix the clang warning of extraneous
> parentheses.
> 
> Signed-off-by: Varsha Rao <rvarsha016@gmail.com>
> ---
>  drivers/infiniband/core/cma.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied to for-next, thanks

Curious, what configuration are you using clang with? I'd like to have
it run here..

Jason

Re: [PATCH] drivers: infiniband: core: Remove extra parentheses

[Varsha Rao]

[-- Attachment #1: Type: text/plain, Size: 714 bytes --]

Hi Jason,

On Wed, Jul 25, 2018 at 10:37 PM, Jason Gunthorpe <jgg@ziepe.ca> wrote:

> On Wed, Jul 25, 2018 at 08:43:56PM +0200, Varsha Rao wrote:
> > Remove unnecessary parentheses to fix the clang warning of extraneous
> > parentheses.
> >
> > Signed-off-by: Varsha Rao <rvarsha016@gmail.com>
> > ---
> >  drivers/infiniband/core/cma.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
>
> Applied to for-next, thanks
>
> Curious, what configuration are you using clang with? I'd like to have
> it run here..
>
> I have the list of warnings from previous kernel build, for which
compiling with clang was possible. I sent the patch as the warning was
still valid for the latest kernel too.

Thanks,
Varsha

[-- Attachment #2: Type: text/html, Size: 1377 bytes --]