From: Jason Gunthorpe <jgg@ziepe.ca>
To: Erez Shitrit <erezsh@dev.mellanox.co.il>
Cc: Aaron Knister <aaron.s.knister@nasa.gov>,
RDMA mailing list <linux-rdma@vger.kernel.org>,
stable@vger.kernel.org, Ira Weiny <ira.weiny@intel.com>,
John Fleck <john.fleck@intel.com>,
Feras Daoud <ferasda@mellanox.com>
Subject: Re: [PATCH v2] avoid race condition between start_xmit and cm_rep_handler
Date: Mon, 20 Aug 2018 10:28:00 -0600 [thread overview]
Message-ID: <20180820162800.GA25543@ziepe.ca> (raw)
In-Reply-To: <CAAk-MO97rinpQXhyy7VZA6HWNwm94UuWAFnLFOSb4mj1wW4fQw@mail.gmail.com>
On Mon, Aug 20, 2018 at 09:36:53AM +0300, Erez Shitrit wrote:
> Hi,
>
> Did you check the option to hold the netif_tx_lock_xxx() in
> ipoib_cm_rep_handler function (over the line
> set_bit(IPOIB_FLAG_OPER_UP)) instead of in the send data path flow?
That does seem better, then the test_bit in the datapath could become
non-atomic too :)
Jason
next prev parent reply other threads:[~2018-08-20 16:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-17 21:31 [PATCH v2] avoid race condition between start_xmit and cm_rep_handler Aaron Knister
2018-08-19 17:28 ` Leon Romanovsky
2018-08-20 4:38 ` Weiny, Ira
2018-08-20 4:34 ` Weiny, Ira
2018-08-20 6:36 ` Erez Shitrit
2018-08-20 16:28 ` Jason Gunthorpe [this message]
2018-08-20 17:40 ` Aaron Knister
2018-08-20 19:20 ` [non-nasa source] " Aaron Knister
2018-08-23 23:25 ` Aaron Knister
2018-08-24 12:34 ` Aaron Knister
2018-08-20 11:49 ` Estrin, Alex
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180820162800.GA25543@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=aaron.s.knister@nasa.gov \
--cc=erezsh@dev.mellanox.co.il \
--cc=ferasda@mellanox.com \
--cc=ira.weiny@intel.com \
--cc=john.fleck@intel.com \
--cc=linux-rdma@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox