From: Leon Romanovsky <leon@kernel.org>
To: Igor Stoppa <igor.stoppa@gmail.com>
Cc: Faisal Latif <faisal.latif@intel.com>,
Igor Stoppa <igor.stoppa@huawei.com>,
Chien Tung <chien.tin.tung@intel.com>,
Roland Dreier <rolandd@cisco.com>, Jason Gunthorpe <jgg@ziepe.ca>,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] infiniband: nes: add unlikely() to assert()
Date: Wed, 5 Sep 2018 09:01:06 +0300 [thread overview]
Message-ID: <20180905060106.GI2977@mtr-leonro.mtl.com> (raw)
In-Reply-To: <20180831192418.12346-1-igor.stoppa@huawei.com>
[-- Attachment #1: Type: text/plain, Size: 373 bytes --]
On Fri, Aug 31, 2018 at 10:24:18PM +0300, Igor Stoppa wrote:
> Typically the assert is expected to not fail.
This whole assert can be removed.
>
> Signed-off-by: Igor Stoppa <igor.stoppa@huawei.com>
> Acked-by: Doug Ledford <dledford@redhat.com>
Most probably that I missed discussion, but anyway, does this
"Acked-by" come from internal or external discussion?
Thanks
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
next prev parent reply other threads:[~2018-09-05 6:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-31 19:24 [PATCH] infiniband: nes: add unlikely() to assert() Igor Stoppa
2018-09-05 6:01 ` Leon Romanovsky [this message]
2018-09-05 18:54 ` Igor Stoppa
2018-09-07 15:13 ` Doug Ledford
2018-09-07 15:25 ` Igor Stoppa
2018-09-07 17:31 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180905060106.GI2977@mtr-leonro.mtl.com \
--to=leon@kernel.org \
--cc=chien.tin.tung@intel.com \
--cc=faisal.latif@intel.com \
--cc=igor.stoppa@gmail.com \
--cc=igor.stoppa@huawei.com \
--cc=jgg@ziepe.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=rolandd@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox