From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH v5 07/13] block: Add PCI P2P flag for request queue and check support for requests Date: Tue, 11 Sep 2018 09:10:55 +0200 Message-ID: <20180911071055.GA6609@lst.de> References: <20180905201152.GA1893@lst.de> <2a3394bd-5f13-4818-43f4-dfc61f501e05@kernel.dk> <3af4d1d4-da07-c0a6-8464-9ddc1378f2f4@kernel.dk> <34d9b2f7-9e6d-4a0a-77e5-ec0e99610f5c@kernel.dk> <20180910164144.GA24591@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Logan Gunthorpe Cc: Christoph Hellwig , Jens Axboe , linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-nvme@lists.infradead.org, linux-rdma@vger.kernel.org, linux-nvdimm@lists.01.org, linux-block@vger.kernel.org, Stephen Bates , Keith Busch , Sagi Grimberg , Bjorn Helgaas , Jason Gunthorpe , Max Gurtovoy , Dan Williams , =?iso-8859-1?B?Suly9G1l?= Glisse , Benjamin Herrenschmidt , Alex Williamson , Christian =?iso-8859-1?Q?K=F6nig?= List-Id: linux-rdma@vger.kernel.org On Mon, Sep 10, 2018 at 12:11:01PM -0600, Logan Gunthorpe wrote: > > I just saw you added that "helper" in your tree. Please don't, it is > > a negative value add as it doesn't help anything with the checking. > > Alright, so what's the consensus then? Just have a check in > nvmet_bdev_execute_rw() to add REQ_NOMERGE when appropriate? Yes.