Re: [PATCH] net/mlx5e: fix high stack usage

Eric Dumazet
2018-11-02T21:39:11Z

On 11/02/2018 02:05 PM, Saeed Mahameed wrote:

> temp will be mem copied to priv->stats.sw at the end,
> memcpy(&priv->stats.sw, &s, sizeof(s));
>
> one other way to solve this as suggested by Andrew, is to get rid of
> the temp var and make it point directly to priv->stats.sw
>

What about concurrency ?

This temp variable is there to make sure concurrent readers of stats might
not see mangle data (because another 'reader' just did a memset() and is doing the folding)

mlx5e_get_stats() can definitely be run at the same time by multiple threads.