From mboxrd@z Thu Jan 1 00:00:00 1970 From: kbuild test robot Subject: [PATCH] RDMA/uverbs: fix ptr_ret.cocci warnings Date: Wed, 28 Nov 2018 07:21:30 +0800 Message-ID: <20181127232130.GA28456@sof-kbuild01> References: <201811280723.DnTk8AXL%fengguang.wu@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <201811280723.DnTk8AXL%fengguang.wu@intel.com> Sender: linux-kernel-owner@vger.kernel.org To: Jason Gunthorpe Cc: kbuild-all@01.org, Leon Romanovsky , Doug Ledford , Yishai Hadas , Mark Bloch , Matan Barak , Ariel Levkovich , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-rdma@vger.kernel.org From: kbuild test robot drivers/infiniband/core/uverbs_cmd.c:1095:1-3: WARNING: PTR_ERR_OR_ZERO can be used Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR Generated by: scripts/coccinelle/api/ptr_ret.cocci Fixes: 7106a9769715 ("RDMA/uverbs: Make write() handlers return 0 on success") Signed-off-by: kbuild test robot --- tree: git://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma for-next head: 07f05f40d956d40f32852a7b3ff109a72d254cf9 commit: 7106a9769715bb4c0448927a29aa3b505855871c [31/37] RDMA/uverbs: Make write() handlers return 0 on success uverbs_cmd.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) --- a/drivers/infiniband/core/uverbs_cmd.c +++ b/drivers/infiniband/core/uverbs_cmd.c @@ -1092,10 +1092,7 @@ static int ib_uverbs_create_cq(struct uv sizeof(cmd.comp_channel), ib_uverbs_create_cq_cb, NULL); - if (IS_ERR(obj)) - return PTR_ERR(obj); - - return 0; + return PTR_ERR_OR_ZERO(obj); } static int ib_uverbs_ex_create_cq_cb(struct uverbs_attr_bundle *attrs,