From: Greg KH <gregkh@linuxfoundation.org>
To: Leon Romanovsky <leon@kernel.org>
Cc: stable@vger.kernel.org, linux-rdma@vger.kernel.org,
Parav Pandit <parav@mellanox.com>,
Jack Morgenstein <jackm@dev.mellanox.co.il>,
Jason Gunthorpe <jgg@mellanox.com>
Subject: Re: [PATCH] IB/core: Perform modify QP on real one
Date: Wed, 28 Nov 2018 11:58:20 +0100 [thread overview]
Message-ID: <20181128105820.GC1822@kroah.com> (raw)
In-Reply-To: <20181029151223.15114-1-leon@kernel.org>
On Mon, Oct 29, 2018 at 05:12:23PM +0200, Leon Romanovsky wrote:
> From: Parav Pandit <parav@mellanox.com>
>
> commit b2bedfb39541a7e14798d066b6f8685d84c8fcf5 upstream
>
> Currently qp->port stores the port number whenever IB_QP_PORT
> QP attribute mask is set (during QP state transition to INIT state).
> This port number should be stored for the real QP when XRC target QP
> is used.
>
> Follow the ib_modify_qp() implementation and hide the access to ->real_qp.
>
> This commit is required for proper operation of commit 65be9cbe1224
> ("RDMA/uverbs: Expand primary and alt AV port checks") which was added
> to 4.14.61.
>
> Without this commit, XRC qp's do not work.
>
> Fixes: a512c2fbef9c ("IB/core: Introduce modify QP operation with udata")
> Signed-off-by: Jack Morgenstein <jackm@dev.mellanox.co.il>
> Signed-off-by: Parav Pandit <parav@mellanox.com>
> Reviewed-by: Daniel Jurgens <danielj@mellanox.com>
> Signed-off-by: Leon Romanovsky <leon@kernel.org>
> Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
> ---
> drivers/infiniband/core/verbs.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
Does not apply to the 4.14.y tree :(
next prev parent reply other threads:[~2018-11-28 10:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-29 15:12 [PATCH] IB/core: Perform modify QP on real one Leon Romanovsky
2018-11-28 10:58 ` Greg KH [this message]
2018-11-28 11:26 ` Leon Romanovsky
2018-11-28 13:08 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181128105820.GC1822@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=jackm@dev.mellanox.co.il \
--cc=jgg@mellanox.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=parav@mellanox.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).