From: Saeed Mahameed <saeedm@mellanox.com>
To: Leon Romanovsky <leonro@mellanox.com>, saeedm@mellanox.com
Cc: netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
Jason Gunthorpe <jgg@mellanox.com>,
Or Gerlitz <ogerlitz@mellanox.com>
Subject: [PATCH mlx5-next 09/10] IB/mlx5: Simplify netdev unbinding
Date: Sun, 9 Dec 2018 19:04:41 -0800 [thread overview]
Message-ID: <20181210030442.7543-10-saeedm@mellanox.com> (raw)
In-Reply-To: <20181210030442.7543-1-saeedm@mellanox.com>
From: Or Gerlitz <ogerlitz@mellanox.com>
When dealing with netdev unregister events, we just need to
know that this is our currently bounded netdev. There's no
need to do any further checks/queries.
This patch doesn't change any functionality.
Signed-off-by: Or Gerlitz <ogerlitz@mellanox.com>
Reviewed-by: Mark Bloch <markb@mellanox.com>
Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>
---
drivers/infiniband/hw/mlx5/main.c | 14 +++++++++-----
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/drivers/infiniband/hw/mlx5/main.c b/drivers/infiniband/hw/mlx5/main.c
index 2560996fce79..fd8cbf58f0bf 100644
--- a/drivers/infiniband/hw/mlx5/main.c
+++ b/drivers/infiniband/hw/mlx5/main.c
@@ -172,7 +172,6 @@ static int mlx5_netdev_event(struct notifier_block *this,
switch (event) {
case NETDEV_REGISTER:
- case NETDEV_UNREGISTER:
write_lock(&roce->netdev_lock);
if (ibdev->rep) {
struct mlx5_eswitch *esw = ibdev->mdev->priv.eswitch;
@@ -181,15 +180,20 @@ static int mlx5_netdev_event(struct notifier_block *this,
rep_ndev = mlx5_ib_get_rep_netdev(esw,
ibdev->rep->vport);
if (rep_ndev == ndev)
- roce->netdev = (event == NETDEV_UNREGISTER) ?
- NULL : ndev;
+ roce->netdev = ndev;
} else if (ndev->dev.parent == &mdev->pdev->dev) {
- roce->netdev = (event == NETDEV_UNREGISTER) ?
- NULL : ndev;
+ roce->netdev = ndev;
}
write_unlock(&roce->netdev_lock);
break;
+ case NETDEV_UNREGISTER:
+ write_lock(&roce->netdev_lock);
+ if (roce->netdev == ndev)
+ roce->netdev = NULL;
+ write_unlock(&roce->netdev_lock);
+ break;
+
case NETDEV_CHANGE:
case NETDEV_UP:
case NETDEV_DOWN: {
--
2.19.2
next prev parent reply other threads:[~2018-12-10 3:04 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-10 3:04 [PATCH mlx5-next 00/10] mlx5 core updates and cleanups Saeed Mahameed
2018-12-10 3:04 ` [PATCH mlx5-next 01/10] net/mlx5: Rework handling of port module events Saeed Mahameed
2018-12-10 16:09 ` Jason Gunthorpe
2018-12-10 19:07 ` Saeed Mahameed
2018-12-10 3:04 ` [PATCH mlx5-next 02/10] net/mlx5: Add support for PCIe power slot exceeded error in PME Saeed Mahameed
2018-12-10 3:04 ` [PATCH mlx5-next 03/10] net/mlx5: Add support for plugged-disabled cable status " Saeed Mahameed
2018-12-10 3:04 ` [PATCH mlx5-next 04/10] net/mlx5: Add monitor commands layout and event data Saeed Mahameed
2018-12-10 3:04 ` [PATCH mlx5-next 05/10] net/mlx5: Revise gre and nvgre key formats Saeed Mahameed
2018-12-10 3:04 ` [PATCH mlx5-next 06/10] net/mlx5: Introduce extended destination fields Saeed Mahameed
2018-12-10 3:04 ` [PATCH mlx5-next 07/10] net/mlx5: E-Switch, Change vhca id valid bool field to bit flag Saeed Mahameed
2018-12-10 16:12 ` Jason Gunthorpe
2018-12-10 19:12 ` Saeed Mahameed
2018-12-10 21:05 ` Or Gerlitz
2018-12-10 21:18 ` Saeed Mahameed
2018-12-10 19:51 ` Or Gerlitz
2018-12-10 3:04 ` [PATCH mlx5-next 08/10] net/mlx5: Support extended destination format in flow steering command Saeed Mahameed
2018-12-10 16:16 ` Jason Gunthorpe
2018-12-10 19:13 ` Saeed Mahameed
2018-12-10 3:04 ` Saeed Mahameed [this message]
2018-12-10 3:04 ` [PATCH mlx5-next 10/10] net/mlx5: Remove the get protocol device interface entry Saeed Mahameed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181210030442.7543-10-saeedm@mellanox.com \
--to=saeedm@mellanox.com \
--cc=jgg@mellanox.com \
--cc=leonro@mellanox.com \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox