* [PATCH net-next] net/mlx5: Remove duplicated include from eswitch.c
@ 2018-12-12 8:03 YueHaibing
2018-12-12 15:10 ` Leon Romanovsky
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: YueHaibing @ 2018-12-12 8:03 UTC (permalink / raw)
To: Saeed Mahameed, Leon Romanovsky
Cc: YueHaibing, netdev, linux-rdma, kernel-janitors
Remove duplicated include.
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/net/ethernet/mellanox/mlx5/core/eswitch.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/eswitch.c b/drivers/net/ethernet/mellanox/mlx5/core/eswitch.c
index e6a9b19..4f9dd0d 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/eswitch.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/eswitch.c
@@ -39,7 +39,6 @@
#include "lib/eq.h"
#include "eswitch.h"
#include "fs_core.h"
-#include "lib/eq.h"
#define UPLINK_VPORT 0xFFFF
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH net-next] net/mlx5: Remove duplicated include from eswitch.c
2018-12-12 8:03 [PATCH net-next] net/mlx5: Remove duplicated include from eswitch.c YueHaibing
@ 2018-12-12 15:10 ` Leon Romanovsky
2018-12-12 18:55 ` David Miller
2018-12-13 1:17 ` Saeed Mahameed
2 siblings, 0 replies; 6+ messages in thread
From: Leon Romanovsky @ 2018-12-12 15:10 UTC (permalink / raw)
To: YueHaibing; +Cc: Saeed Mahameed, netdev, linux-rdma, kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 303 bytes --]
On Wed, Dec 12, 2018 at 08:03:38AM +0000, YueHaibing wrote:
> Remove duplicated include.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/net/ethernet/mellanox/mlx5/core/eswitch.c | 1 -
> 1 file changed, 1 deletion(-)
>
Thanks,
Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net-next] net/mlx5: Remove duplicated include from eswitch.c
2018-12-12 8:03 [PATCH net-next] net/mlx5: Remove duplicated include from eswitch.c YueHaibing
2018-12-12 15:10 ` Leon Romanovsky
@ 2018-12-12 18:55 ` David Miller
2018-12-12 20:27 ` Saeed Mahameed
2018-12-13 1:17 ` Saeed Mahameed
2 siblings, 1 reply; 6+ messages in thread
From: David Miller @ 2018-12-12 18:55 UTC (permalink / raw)
To: yuehaibing; +Cc: saeedm, leon, netdev, linux-rdma, kernel-janitors
From: YueHaibing <yuehaibing@huawei.com>
Date: Wed, 12 Dec 2018 08:03:38 +0000
> Remove duplicated include.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Saeed, how would you like me to handle small fixes like this which have been
explicitly ACK'd by a Mellanox developer?
Do you want me to apply them directly or wait to get them from you in your
next pull request?
Thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net-next] net/mlx5: Remove duplicated include from eswitch.c
2018-12-12 18:55 ` David Miller
@ 2018-12-12 20:27 ` Saeed Mahameed
2018-12-13 0:42 ` David Miller
0 siblings, 1 reply; 6+ messages in thread
From: Saeed Mahameed @ 2018-12-12 20:27 UTC (permalink / raw)
To: yuehaibing@huawei.com, davem@davemloft.net
Cc: netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
leon@kernel.org, kernel-janitors@vger.kernel.org
On Wed, 2018-12-12 at 10:55 -0800, David Miller wrote:
> From: YueHaibing <yuehaibing@huawei.com>
> Date: Wed, 12 Dec 2018 08:03:38 +0000
>
> > Remove duplicated include.
> >
> > Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>
> Saeed, how would you like me to handle small fixes like this which
> have been
> explicitly ACK'd by a Mellanox developer?
>
> Do you want me to apply them directly or wait to get them from you in
> your
> next pull request?
>
Let's do the following, if I ACK them then you can apply them directly,
otherwise i will notify and apply them to my branch and send them later
to avoid any confusion or conflict with our shared branch.
Does that work for you ? if not then you can always leave them to me.
Thanks !
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net-next] net/mlx5: Remove duplicated include from eswitch.c
2018-12-12 20:27 ` Saeed Mahameed
@ 2018-12-13 0:42 ` David Miller
0 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2018-12-13 0:42 UTC (permalink / raw)
To: saeedm; +Cc: yuehaibing, netdev, linux-rdma, leon, kernel-janitors
From: Saeed Mahameed <saeedm@mellanox.com>
Date: Wed, 12 Dec 2018 20:27:59 +0000
> On Wed, 2018-12-12 at 10:55 -0800, David Miller wrote:
>> From: YueHaibing <yuehaibing@huawei.com>
>> Date: Wed, 12 Dec 2018 08:03:38 +0000
>>
>> > Remove duplicated include.
>> >
>> > Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>>
>> Saeed, how would you like me to handle small fixes like this which
>> have been
>> explicitly ACK'd by a Mellanox developer?
>>
>> Do you want me to apply them directly or wait to get them from you in
>> your
>> next pull request?
>>
>
> Let's do the following, if I ACK them then you can apply them directly,
> otherwise i will notify and apply them to my branch and send them later
> to avoid any confusion or conflict with our shared branch.
>
> Does that work for you ? if not then you can always leave them to me.
That works for me, I'll apply directly only with your explicit ACK,
thanks Saeed.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net-next] net/mlx5: Remove duplicated include from eswitch.c
2018-12-12 8:03 [PATCH net-next] net/mlx5: Remove duplicated include from eswitch.c YueHaibing
2018-12-12 15:10 ` Leon Romanovsky
2018-12-12 18:55 ` David Miller
@ 2018-12-13 1:17 ` Saeed Mahameed
2 siblings, 0 replies; 6+ messages in thread
From: Saeed Mahameed @ 2018-12-13 1:17 UTC (permalink / raw)
To: yuehaibing@huawei.com, leon@kernel.org
Cc: netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
kernel-janitors@vger.kernel.org
On Wed, 2018-12-12 at 08:03 +0000, YueHaibing wrote:
> Remove duplicated include.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>
Applied to mlx5-next
Thanks!
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-12-13 1:17 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-12-12 8:03 [PATCH net-next] net/mlx5: Remove duplicated include from eswitch.c YueHaibing
2018-12-12 15:10 ` Leon Romanovsky
2018-12-12 18:55 ` David Miller
2018-12-12 20:27 ` Saeed Mahameed
2018-12-13 0:42 ` David Miller
2018-12-13 1:17 ` Saeed Mahameed
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox