Re: [PATCH] lib/scatterlist: Provide a DMA page iterator

From: kbuild test robot <lkp@intel.com>
To: Jason Gunthorpe <jgg@mellanox.com>
Cc: Thomas Hellstrom <thellstrom@vmware.com>,
	Sinclair Yeh <syeh@vmware.com>,
	"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
	Daniel Vetter <daniel.vetter@ffwll.ch>,
	Jian Xu Zheng <jian.xu.zheng@intel.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	kbuild-all@01.org, Sakari Ailus <sakari.ailus@linux.intel.com>,
	Bingbu Cao <bingbu.cao@intel.com>, Yong Zhi <yong.zhi@intel.com>,
	Shiraz Saleem <shiraz.saleem@intel.com>,
	Christoph Hellwig <hch@lst.de>,
	Tian Shu Qiu <tian.shu.qiu@intel.com>,
	"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>
Subject: Re: [PATCH] lib/scatterlist: Provide a DMA page iterator
Date: Sat, 5 Jan 2019 10:37:17 +0800	[thread overview]
Message-ID: <201901051046.ew7HAHfl%fengguang.wu@intel.com> (raw)
In-Reply-To: <20190104223531.GA1705@ziepe.ca>

[-- Attachment #1: Type: text/plain, Size: 3095 bytes --]

Hi Jason,

I love your patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v4.20 next-20190103]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Jason-Gunthorpe/lib-scatterlist-Provide-a-DMA-page-iterator/20190105-081739
config: x86_64-randconfig-x017-201900 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All error/warnings (new ones prefixed by >>):

   In file included from lib/scatterlist.c:9:0:
>> include/linux/export.h:81:20: error: redefinition of '__kstrtab___sg_page_iter_next'
     static const char __kstrtab_##sym[]    \
                       ^
   include/linux/export.h:120:25: note: in expansion of macro '___EXPORT_SYMBOL'
    #define __EXPORT_SYMBOL ___EXPORT_SYMBOL
                            ^~~~~~~~~~~~~~~~
   include/linux/export.h:124:2: note: in expansion of macro '__EXPORT_SYMBOL'
     __EXPORT_SYMBOL(sym, "")
     ^~~~~~~~~~~~~~~
>> lib/scatterlist.c:652:1: note: in expansion of macro 'EXPORT_SYMBOL'
    EXPORT_SYMBOL(__sg_page_iter_next);
    ^~~~~~~~~~~~~
   include/linux/export.h:81:20: note: previous definition of '__kstrtab___sg_page_iter_next' was here
     static const char __kstrtab_##sym[]    \
                       ^
   include/linux/export.h:120:25: note: in expansion of macro '___EXPORT_SYMBOL'
    #define __EXPORT_SYMBOL ___EXPORT_SYMBOL
                            ^~~~~~~~~~~~~~~~
   include/linux/export.h:124:2: note: in expansion of macro '__EXPORT_SYMBOL'
     __EXPORT_SYMBOL(sym, "")
     ^~~~~~~~~~~~~~~
   lib/scatterlist.c:626:1: note: in expansion of macro 'EXPORT_SYMBOL'
    EXPORT_SYMBOL(__sg_page_iter_next);
    ^~~~~~~~~~~~~

vim +/__kstrtab___sg_page_iter_next +81 include/linux/export.h

7290d580 Ard Biesheuvel  2018-08-21  76  
f5016932 Paul Gortmaker  2011-05-23  77  /* For every exported symbol, place a struct in the __ksymtab section */
f2355416 Nicolas Pitre   2016-01-22  78  #define ___EXPORT_SYMBOL(sym, sec)					\
f5016932 Paul Gortmaker  2011-05-23  79  	extern typeof(sym) sym;						\
f5016932 Paul Gortmaker  2011-05-23  80  	__CRC_SYMBOL(sym, sec)						\
f5016932 Paul Gortmaker  2011-05-23 @81  	static const char __kstrtab_##sym[]				\
7290d580 Ard Biesheuvel  2018-08-21  82  	__attribute__((section("__ksymtab_strings"), used, aligned(1)))	\
94e58e0a Masahiro Yamada 2018-05-09  83  	= #sym;								\
7290d580 Ard Biesheuvel  2018-08-21  84  	__KSYMTAB_ENTRY(sym, sec)
f5016932 Paul Gortmaker  2011-05-23  85  

:::::: The code at line 81 was first introduced by commit
:::::: f50169324df4ad942e544386d136216c8617636a module.h: split out the EXPORT_SYMBOL into export.h

:::::: TO: Paul Gortmaker <paul.gortmaker@windriver.com>
:::::: CC: Paul Gortmaker <paul.gortmaker@windriver.com>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 29169 bytes --]

[-- Attachment #3: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel