From: Jason Gunthorpe <jgg@ziepe.ca>
To: Adit Ranadive <aditr@vmware.com>
Cc: "dledford@redhat.com" <dledford@redhat.com>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
Pv-drivers <Pv-drivers@vmware.com>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH v1 for-rc] RDMA/vmw_pvrdma: Return the correct opcode when creating WR
Date: Tue, 8 Jan 2019 16:48:57 -0700 [thread overview]
Message-ID: <20190108234857.GC30436@ziepe.ca> (raw)
In-Reply-To: <01aef10a-8b54-5ff5-0f90-d74d8c4c70cc@vmware.com>
On Tue, Jan 08, 2019 at 06:39:02PM +0000, Adit Ranadive wrote:
> >> Not sure if I follow you. We can post a failure but that would be
> >> in pvrdma_qp.c when it looks at the opcode returned from here. We
> >> would have to handle all the IB enums here though if you don't want
> >> a default case (you would get compiler warnings otherwise).
> >
> > You'd do something like
> >
> > default:
> > return PVRDMA_WR_ERROR;
> >
> > And something, somewhere, should fail the posting.
> >
> > Jason
> >
>
> Okay. So maybe something like this, would work:
Yes, this is what I was thinking, please send a patch
Jason
prev parent reply other threads:[~2019-01-08 23:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-07 23:23 [PATCH v1 for-rc] RDMA/vmw_pvrdma: Return the correct opcode when creating WR Adit Ranadive
2019-01-07 23:28 ` Jason Gunthorpe
2019-01-08 0:02 ` Adit Ranadive
2019-01-08 3:10 ` Jason Gunthorpe
2019-01-08 18:39 ` Adit Ranadive
2019-01-08 23:48 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190108234857.GC30436@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=Pv-drivers@vmware.com \
--cc=aditr@vmware.com \
--cc=dledford@redhat.com \
--cc=linux-rdma@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox