From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Pirko Subject: Re: [PATCH net-next v3 05/12] mlxsw: Implement ndo_get_port_parent_id() Date: Wed, 6 Feb 2019 14:14:38 +0100 Message-ID: <20190206131438.GF2189@nanopsycho> References: <20190205235326.14600-1-f.fainelli@gmail.com> <20190205235326.14600-6-f.fainelli@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20190205235326.14600-6-f.fainelli@gmail.com> Sender: netdev-owner@vger.kernel.org To: Florian Fainelli Cc: netdev@vger.kernel.org, "David S. Miller" , Ido Schimmel , open list , "open list:MELLANOX MLX5 core VPI driver" , "open list:NETRONOME ETHERNET DRIVERS" , "open list:STAGING SUBSYSTEM" , "moderated list:ETHERNET BRIDGE" List-Id: linux-rdma@vger.kernel.org Wed, Feb 06, 2019 at 12:53:19AM CET, f.fainelli@gmail.com wrote: >mlxsw implements SWITCHDEV_ATTR_ID_PORT_PARENT_ID and we want to get rid >of switchdev_ops eventually, ease that migration by implementing a >ndo_get_port_parent_id() function which returns what >switchdev_port_attr_get() would do. > >Signed-off-by: Florian Fainelli [...] >diff --git a/drivers/net/ethernet/mellanox/mlxsw/switchx2.c b/drivers/net/ethernet/mellanox/mlxsw/switchx2.c >index 2d4f213e154d..3814ba8af517 100644 >--- a/drivers/net/ethernet/mellanox/mlxsw/switchx2.c >+++ b/drivers/net/ethernet/mellanox/mlxsw/switchx2.c Please remove net/switchdev.h inclusion from this file, you don't need it any longer. Otherwise, looks fine. Acked-by: Jiri Pirko [...]