From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ido Schimmel Subject: Re: [PATCH net-next v4 01/12] net: Introduce ndo_get_port_parent_id() Date: Wed, 6 Feb 2019 19:10:56 +0000 Message-ID: <20190206191054.GC14340@splinter> References: <20190206174546.23597-1-f.fainelli@gmail.com> <20190206174546.23597-2-f.fainelli@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <20190206174546.23597-2-f.fainelli@gmail.com> Content-Language: en-US Content-ID: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: bridge-bounces@lists.linux-foundation.org Errors-To: bridge-bounces@lists.linux-foundation.org To: Florian Fainelli Cc: "open list:STAGING SUBSYSTEM" , "open list:MELLANOX MLX5 core VPI driver" , "netdev@vger.kernel.org" , "moderated list:ETHERNET BRIDGE" , open list , "open list:NETRONOME ETHERNET DRIVERS" , "David S. Miller" List-Id: linux-rdma@vger.kernel.org On Wed, Feb 06, 2019 at 09:45:35AM -0800, Florian Fainelli wrote: > In preparation for getting rid of switchdev_ops, create a dedicated NDO > operation for getting the port's parent identifier. There are > essentially two classes of drivers that need to implement getting the > port's parent ID which are VF/PF drivers with a built-in switch, and > pure switchdev drivers such as mlxsw, ocelot, dsa etc. >=20 > We introduce a helper function: dev_get_port_parent_id() which supports > recursion into the lower devices to obtain the first port's parent ID. >=20 > Convert the bridge, core and ipv4 multicast routing code to check for > such ndo_get_port_parent_id() and call the helper function when valid > before falling back to switchdev_port_attr_get(). This will allow us to > convert all relevant drivers in one go instead of having to implement > both switchdev_port_attr_get() and ndo_get_port_parent_id() operations, > then get rid of switchdev_port_attr_get(). >=20 > Acked-by: Jiri Pirko > Signed-off-by: Florian Fainelli Reviewed-by: Ido Schimmel