Re: [PATCH v2] RDMA/umem: minor bug fix and cleanup in error handling paths

John Hubbard
2019-03-06T02:04:35Z

On 3/5/19 5:51 PM, Jason Gunthorpe wrote:
> On Tue, Mar 05, 2019 at 05:37:18PM -0800, John Hubbard wrote:
>> On 3/5/19 5:34 PM, John Hubbard wrote:
>> [snip]
>>>>> So release_pages(&local_page_list[j+1], npages - j-1) would be correct.
>>>>
>>>> Someone send a fixup patch please...
>>>>
>>>> Jason
>>>
>>> Yeah, I'm on it. Just need to double-check that this is the case. But Jason,
>>> you're confirming it already, so that helps too.
>
> I didn't look, just assuming Artemy is right since he knows this
> code..
>

OK. And I've confirmed it, too.

>>> Patch coming shortly.
>>>
>>
>> Jason, btw, do you prefer a patch that fixes the previous one, or a new
>> patch that stands alone? (I'm not sure how this tree is maintained, exactly.)
>
> It has past the point when I should apply a fixup, rdma is general has
> about an approximately 1 day period after the 'thanks applied' message
> where rebase is possible
>
> Otherwise the tree is strictly no rebase
>
> Jason
>

Got it, patch is posted now.

thanks,
--
John Hubbard
NVIDIA