From: Jason Gunthorpe <jgg@ziepe.ca>
To: Dennis Dalessandro <dennis.dalessandro@intel.com>
Cc: dledford@redhat.com, linux-rdma@vger.kernel.org,
"Michael J. Ruhl" <michael.j.ruhl@intel.com>,
Mike Marciniszyn <mike.marciniszyn@intel.com>,
stable@vger.kernel.org
Subject: Re: [PATCH for-next 3/3] IB/hfi1: Close race condition on user context disable and close
Date: Mon, 4 Mar 2019 16:41:53 -0400 [thread overview]
Message-ID: <20190304204153.GF8613@ziepe.ca> (raw)
In-Reply-To: <316cda1d-eeaa-c75a-a4d8-fb087cd38714@intel.com>
On Tue, Feb 26, 2019 at 12:15:59PM -0500, Dennis Dalessandro wrote:
> On 2/26/2019 11:45 AM, Dennis Dalessandro wrote:
> > struct hfi1_ctxtdata *hfi1_rcd_get_by_index(struct hfi1_devdata *dd, u16 ctxt);
> > diff --git a/drivers/infiniband/hw/hfi1/init.c b/drivers/infiniband/hw/hfi1/init.c
> > index 7841a0a..2cc5164 100644
> > +++ b/drivers/infiniband/hw/hfi1/init.c
> > @@ -214,12 +214,12 @@ static void hfi1_rcd_free(struct kref *kref)
> > struct hfi1_ctxtdata *rcd =
> > container_of(kref, struct hfi1_ctxtdata, kref);
> > - hfi1_free_ctxtdata(rcd->dd, rcd);
> > -
> > spin_lock_irqsave(&rcd->dd->uctxt_lock, flags);
> > rcd->dd->rcd[rcd->ctxt] = NULL;
> > spin_unlock_irqrestore(&rcd->dd->uctxt_lock, flags);
> > + hfi1_free_ctxtdata(rcd->dd, rcd);
> > +
> > kfree(rcd);
> > }
> Whoops, hold off on pulling this one just yet. We need to take a closer look
> at the above hunk.
Oh, okay.. Please resend it
Jason
next prev parent reply other threads:[~2019-03-04 20:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-26 16:45 [PATCH for-next 0/3] Driver fixes Dennis Dalessandro
2019-02-26 16:45 ` [PATCH for-next 1/3] IB/rdmavt: Fix loopback send with invalidate ordering Dennis Dalessandro
2019-02-26 16:45 ` [PATCH for-next 2/3] IB/rdmavt: Fix concurrency panics in QP post_send and modify to error Dennis Dalessandro
2019-02-26 16:45 ` [PATCH for-next 3/3] IB/hfi1: Close race condition on user context disable and close Dennis Dalessandro
2019-02-26 17:15 ` Dennis Dalessandro
2019-03-04 20:41 ` Jason Gunthorpe [this message]
2019-03-05 15:30 ` Dennis Dalessandro
2019-03-06 18:47 ` Jason Gunthorpe
2019-03-04 19:49 ` [PATCH for-next 0/3] Driver fixes Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190304204153.GF8613@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=dennis.dalessandro@intel.com \
--cc=dledford@redhat.com \
--cc=linux-rdma@vger.kernel.org \
--cc=michael.j.ruhl@intel.com \
--cc=mike.marciniszyn@intel.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox