From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH v2] RDMA/umem: minor bug fix and cleanup in error handling paths Date: Tue, 5 Mar 2019 21:51:23 -0400 Message-ID: <20190306015123.GB1662@ziepe.ca> References: <20190302032726.11769-2-jhubbard@nvidia.com> <20190302202435.31889-1-jhubbard@nvidia.com> <20190302194402.GA24732@iweiny-DESK2.sc.intel.com> <2404c962-8f6d-1f6d-0055-eb82864ca7fc@mellanox.com> <332021c5-ab72-d54f-85c8-b2b12b76daed@nvidia.com> <903383a6-f2c9-4a69-83c0-9be9c052d4be@mellanox.com> <20190306013213.GA1662@ziepe.ca> <74f196a1-bd27-2e94-2f9f-0cf657eb0c91@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: John Hubbard Cc: Artemy Kovalyov , Ira Weiny , "john.hubbard@gmail.com" , "linux-mm@kvack.org" , Andrew Morton , LKML , Doug Ledford , "linux-rdma@vger.kernel.org" List-Id: linux-rdma@vger.kernel.org On Tue, Mar 05, 2019 at 05:37:18PM -0800, John Hubbard wrote: > On 3/5/19 5:34 PM, John Hubbard wrote: > [snip] > >>> So release_pages(&local_page_list[j+1], npages - j-1) would be correct. > >> > >> Someone send a fixup patch please... > >> > >> Jason > > > > Yeah, I'm on it. Just need to double-check that this is the case. But Jason, > > you're confirming it already, so that helps too. I didn't look, just assuming Artemy is right since he knows this code.. > > Patch coming shortly. > > > > Jason, btw, do you prefer a patch that fixes the previous one, or a new > patch that stands alone? (I'm not sure how this tree is maintained, exactly.) It has past the point when I should apply a fixup, rdma is general has about an approximately 1 day period after the 'thanks applied' message where rebase is possible Otherwise the tree is strictly no rebase Jason