From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH mlx5-next] net/mlx5: Fix DCT creation bad flow Date: Wed, 6 Mar 2019 18:52:16 +0000 Message-ID: <20190306185212.GQ1758@mellanox.com> References: <20190306172050.20033-1-leon@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <20190306172050.20033-1-leon@kernel.org> Content-Language: en-US Content-ID: Sender: netdev-owner@vger.kernel.org To: Leon Romanovsky Cc: Doug Ledford , Yishai Hadas , RDMA mailing list , Artemy Kovalyov , Moni Shoua , Saeed Mahameed , linux-netdev , Leon Romanovsky List-Id: linux-rdma@vger.kernel.org On Wed, Mar 06, 2019 at 07:20:50PM +0200, Leon Romanovsky wrote: > From: Yishai Hadas >=20 > In case the DCT creation command has succeeded a DRAIN must be issued > before calling DESTROY. >=20 > In addition, the original code used the wrong parameter for the DESTROY > command, 'in' instead of 'din', which caused another creation try > instead of destroying. >=20 > Cc: # 4.15 > Fixes: 57cda166bbe0 ("net/mlx5: Add DCT command interface") > Signed-off-by: Yishai Hadas > Reviewed-by: Artemy Kovalyov > Signed-off-by: Leon Romanovsky > Jason, Doug >=20 > If it is possible, I would like to take this patch too: > https://patchwork.kernel.org/patch/10828299/ This should have been applied to the shared tree though?? It is RDMA focused, do you want it to go to the RDMA tree? Jason