public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgg@ziepe.ca>
To: Parav Pandit <parav@mellanox.com>
Cc: "Leon Romanovsky" <leon@kernel.org>,
	"Doug Ledford" <dledford@redhat.com>,
	"Steve Wise" <swise@opengridcomputing.com>,
	"Håkon Bugge" <haakon.bugge@oracle.com>,
	"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] RDMA/cma: Make CM response timeout and # CM retries configurable
Date: Fri, 12 Apr 2019 16:30:24 -0300	[thread overview]
Message-ID: <20190412193024.GB4690@ziepe.ca> (raw)
In-Reply-To: <VI1PR0501MB2271E8A704DD21EF81C7DC24D1710@VI1PR0501MB2271.eurprd05.prod.outlook.com>

On Mon, Mar 04, 2019 at 06:27:26AM +0000, Parav Pandit wrote:

> I think we should use rdma_nl_register(RDMA_NL_RDMA_CM, cma_cb_table) which was removed as part of ID stats removal.
> Because of below reasons.
> 1. rdma netlink command auto loads the module

This is probably the best argument to stay away from sysctl for module
parameters.. It is tricky to make sure the rdma module is loaded
before sysctl runs in boot, and I don't think sysctl autoloads missing
modules, or somehow copes with dynamic module loading, does it?

To that end we should probably have the entire sysctl configurable
available in netlink

Jason

  reply	other threads:[~2019-04-12 19:30 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-17 17:09 [PATCH] RDMA/cma: Make CM response timeout and # CM retries configurable Håkon Bugge
2019-02-22 16:36 ` Jason Gunthorpe
2019-02-22 17:14   ` Steve Wise
2019-02-22 17:51     ` Doug Ledford
2019-02-23  8:49       ` Leon Romanovsky
2019-02-25 17:23         ` Håkon Bugge
2019-03-04  6:27         ` Parav Pandit
2019-04-12 19:30           ` Jason Gunthorpe [this message]
2019-04-12 19:56             ` Leon Romanovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190412193024.GB4690@ziepe.ca \
    --to=jgg@ziepe.ca \
    --cc=dledford@redhat.com \
    --cc=haakon.bugge@oracle.com \
    --cc=leon@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=parav@mellanox.com \
    --cc=swise@opengridcomputing.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox