From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cornelia Huck Subject: Re: [RFC 2/3] hw/virtio-rdma: VirtIO rdma device Date: Tue, 23 Apr 2019 09:59:21 +0200 Message-ID: <20190423095921.3af966b8.cohuck@redhat.com> References: <20190411110157.14252-1-yuval.shaia@oracle.com> <20190411110157.14252-3-yuval.shaia@oracle.com> <20190419191910-mutt-send-email-mst@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190419191910-mutt-send-email-mst@kernel.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: "Michael S. Tsirkin" Cc: linux-rdma@vger.kernel.org, qemu-devel@nongnu.org, Yuval Shaia , virtualization@lists.linux-foundation.org, jgg@mellanox.com List-Id: linux-rdma@vger.kernel.org On Fri, 19 Apr 2019 19:20:22 -0400 "Michael S. Tsirkin" wrote: > On Thu, Apr 11, 2019 at 02:01:56PM +0300, Yuval Shaia wrote: > > diff --git a/include/standard-headers/linux/virtio_ids.h b/include/standard-headers/linux/virtio_ids.h > > index 6d5c3b2d4f..bd2c699450 100644 > > --- a/include/standard-headers/linux/virtio_ids.h > > +++ b/include/standard-headers/linux/virtio_ids.h > > @@ -43,5 +43,6 @@ > > #define VIRTIO_ID_INPUT 18 /* virtio input */ > > #define VIRTIO_ID_VSOCK 19 /* virtio vsock transport */ > > #define VIRTIO_ID_CRYPTO 20 /* virtio crypto */ > > +#define VIRTIO_ID_RDMA 26 /* virtio crypto */ I think 26 is already de facto used by virtio-audio(?) and 27 has just been reserved for virtio-pmem. The next free id seems to be 28. (Also, the comment is a straight copy-paste :) > > > > #endif /* _LINUX_VIRTIO_IDS_H */ > > > Please reserve an ID with the virtio TC. > Process: > - create a github issue > - post patch with Fixes: tag > - wait a bit > - if no comments on either ask for a vote Agreed, let's reserve an id. There seems to be enough interest in this device type.