From: Leon Romanovsky <leon@kernel.org>
To: michal.kalderon@marvell.com, David Miller <davem@davemloft.net>
Cc: ariel.elior@marvell.com, jgg@ziepe.ca, dledford@redhat.com,
linux-rdma@vger.kernel.org, netdev@vger.kernel.org,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH net-next 07/10] qed*: Add iWARP 100g support
Date: Thu, 2 May 2019 08:13:20 +0300 [thread overview]
Message-ID: <20190502051320.GF7676@mtr-leonro.mtl.com> (raw)
In-Reply-To: <20190501.203522.1577716429222042609.davem@davemloft.net>
On Wed, May 01, 2019 at 08:35:22PM -0400, David Miller wrote:
> From: Michal Kalderon <michal.kalderon@marvell.com>
> Date: Wed, 1 May 2019 12:57:19 +0300
>
> > diff --git a/drivers/infiniband/hw/qedr/main.c b/drivers/infiniband/hw/qedr/main.c
> > index d93c8a893a89..8bc6775abb79 100644
> > --- a/drivers/infiniband/hw/qedr/main.c
> > +++ b/drivers/infiniband/hw/qedr/main.c
> > @@ -52,6 +52,10 @@ MODULE_DESCRIPTION("QLogic 40G/100G ROCE Driver");
> > MODULE_AUTHOR("QLogic Corporation");
> > MODULE_LICENSE("Dual BSD/GPL");
> >
> > +static uint iwarp_cmt;
> > +module_param(iwarp_cmt, uint, 0444);
> > +MODULE_PARM_DESC(iwarp_cmt, " iWARP: Support CMT mode. 0 - Disabled, 1 - Enabled. Default: Disabled");
> > +
>
> Sorry no, this is totally beneath us.
It is not acceptable for RDMA too.
Also please don't use comments inside function calls, it complicates
various checkers without real need.
dev->ops->iwarp_set_engine_affin(dev->cdev, true /* reset */);
^^^^^^^^^^^^^^
Thanks
next prev parent reply other threads:[~2019-05-02 5:13 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-01 9:57 [PATCH net-next 00/10] qed*: Improve performance on 100G link for offload protocols Michal Kalderon
2019-05-01 9:57 ` [PATCH net-next 01/10] qed: Modify api for performing a dmae to another PF Michal Kalderon
2019-05-01 9:57 ` [PATCH net-next 02/10] qed: Add llh ppfid interface and 100g support for offload protocols Michal Kalderon
2019-05-02 12:29 ` kbuild test robot
2019-05-01 9:57 ` [PATCH net-next 03/10] qed: Change hwfn used for sb initialization Michal Kalderon
2019-05-01 9:57 ` [PATCH net-next 04/10] qed: Modify offload protocols to use the affined engine Michal Kalderon
2019-05-01 9:57 ` [PATCH net-next 05/10] qedr: Change the MSI-X vectors selection to be based on " Michal Kalderon
2019-05-01 9:57 ` [PATCH net-next 06/10] qed: Set the doorbell address correctly Michal Kalderon
2019-05-01 9:57 ` [PATCH net-next 07/10] qed*: Add iWARP 100g support Michal Kalderon
2019-05-02 0:35 ` David Miller
2019-05-02 5:13 ` Leon Romanovsky [this message]
2019-05-02 12:10 ` [EXT] " Michal Kalderon
2019-05-02 12:31 ` Leon Romanovsky
2019-05-02 20:38 ` Michal Kalderon
2019-05-01 9:57 ` [PATCH net-next 08/10] Revert "scsi: qedi: Allocate IRQs based on msix_cnt" Michal Kalderon
2019-05-01 9:57 ` [PATCH net-next 09/10] qedi: Use hwfns and affin_hwfn_idx to get MSI-X vector index Michal Kalderon
2019-05-01 9:57 ` [PATCH net-next 10/10] qedf: Use hwfns and affin_hwfn_idx to get MSI-X vector index to use Michal Kalderon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190502051320.GF7676@mtr-leonro.mtl.com \
--to=leon@kernel.org \
--cc=ariel.elior@marvell.com \
--cc=davem@davemloft.net \
--cc=dledford@redhat.com \
--cc=jgg@ziepe.ca \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=michal.kalderon@marvell.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox