linux-rdma.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgg@ziepe.ca>
To: Ira Weiny <ira.weiny@intel.com>
Cc: "John Hubbard" <jhubbard@nvidia.com>,
	"Dan Williams" <dan.j.williams@intel.com>,
	"Jan Kara" <jack@suse.cz>, "Theodore Ts'o" <tytso@mit.edu>,
	"Jeff Layton" <jlayton@kernel.org>,
	"Dave Chinner" <david@fromorbit.com>,
	"Matthew Wilcox" <willy@infradead.org>,
	linux-xfs@vger.kernel.org,
	"Andrew Morton" <akpm@linux-foundation.org>,
	"Jérôme Glisse" <jglisse@redhat.com>,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-nvdimm@lists.01.org, linux-ext4@vger.kernel.org,
	linux-mm@kvack.org, linux-rdma@vger.kernel.org
Subject: Re: [PATCH RFC 00/10] RDMA/FS DAX truncate proposal
Date: Thu, 6 Jun 2019 16:46:52 -0300	[thread overview]
Message-ID: <20190606194652.GI17373@ziepe.ca> (raw)
In-Reply-To: <20190606171158.GB11374@iweiny-DESK2.sc.intel.com>

On Thu, Jun 06, 2019 at 10:11:58AM -0700, Ira Weiny wrote:

> 2) This is a bit more subtle and something I almost delayed sending these out
>    for.  Currently the implementation of a lease break actually removes the
>    lease from the file.  I did not want this to happen and I was thinking of
>    delaying this patch set to implement something which keeps the lease around
>    but I figured I should get something out for comments.  Jan has proposed
>    something along these lines and I agree with him so I'm going to ask you to
>    read my response to him about the details.
>
> 
>    Anyway so the key here is that currently an app needs the SIGIO to retake
>    the lease if they want to map the file again or in parts based on usage.
>    For example, they may only want to map some of the file for when they are
>    using it and then map another part later.  Without the SIGIO they would lose
>    their lease or would have to just take the lease for each GUP pin (which
>    adds overhead).  Like I said I did not like this but I left it to get
>    something which works out.

So to be clear.. 

Even though the lease is broken the GUP remains, the pages remain
pined, and truncate/etc continues to fail? 

I like Jan's take on this actually.. see other email.

Jason

  reply	other threads:[~2019-06-06 19:46 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20190606014544.8339-1-ira.weiny@intel.com>
     [not found] ` <c559c2ce-50dc-d143-5741-fe3d21d0305c@nvidia.com>
2019-06-06 17:11   ` [PATCH RFC 00/10] RDMA/FS DAX truncate proposal Ira Weiny
2019-06-06 19:46     ` Jason Gunthorpe [this message]
     [not found] ` <20190606104203.GF7433@quack2.suse.cz>
2019-06-06 22:03   ` Ira Weiny
2019-06-06 22:26     ` Ira Weiny
2019-06-06 22:28     ` Dave Chinner
2019-06-07 11:04     ` Jan Kara
     [not found]       ` <20190607110426.GB12765-4I4JzKEfoa/jFM9bn6wA6Q@public.gmane.org>
2019-06-07 18:25         ` Ira Weiny
2019-06-07 18:50           ` Jason Gunthorpe
     [not found]           ` <20190607182534.GC14559-J5EW/p2F9lUlb2qzJQmr9q2pdiUAq4bhAL8bYrjMMd8@public.gmane.org>
2019-06-08  0:10             ` Dave Chinner
     [not found]               ` <20190608001036.GF14308-pA1nmv6sEBkOM8BvhN4Z8vybgvtCy99p@public.gmane.org>
2019-06-09  1:29                 ` Ira Weiny
2019-06-12 12:37                 ` Matthew Wilcox
     [not found]                   ` <20190612123751.GD32656-PfSpb0PWhxZc2C7mugBRk2EX/6BAtgUQ@public.gmane.org>
2019-06-12 23:30                     ` Ira Weiny
     [not found]                       ` <20190612233024.GD14336-J5EW/p2F9lUlb2qzJQmr9q2pdiUAq4bhAL8bYrjMMd8@public.gmane.org>
2019-06-13  0:55                         ` Dave Chinner
     [not found]                           ` <20190613005552.GI14363-pA1nmv6sEBkOM8BvhN4Z8vybgvtCy99p@public.gmane.org>
2019-06-13 20:34                             ` Ira Weiny
2019-06-14  3:42                               ` Dave Chinner
2019-06-13  0:25                     ` Dave Chinner
     [not found]                       ` <20190613002555.GH14363-pA1nmv6sEBkOM8BvhN4Z8vybgvtCy99p@public.gmane.org>
2019-06-13  3:23                         ` Matthew Wilcox
     [not found]                           ` <20190613032320.GG32656-PfSpb0PWhxZc2C7mugBRk2EX/6BAtgUQ@public.gmane.org>
2019-06-13  4:36                             ` Dave Chinner
     [not found]                               ` <20190613043649.GJ14363-pA1nmv6sEBkOM8BvhN4Z8vybgvtCy99p@public.gmane.org>
2019-06-13 10:47                                 ` Matthew Wilcox
2019-06-13 15:29                           ` Jason Gunthorpe
2019-06-13 15:27                         ` Matthew Wilcox
2019-06-13 21:13                           ` Ira Weiny
2019-06-13 23:45                             ` Jason Gunthorpe
2019-06-14  0:00                               ` Ira Weiny
     [not found]                               ` <20190613234530.GK22901-uk2M96/98Pc@public.gmane.org>
2019-06-14  2:09                                 ` Dave Chinner
2019-06-14  2:31                                   ` Matthew Wilcox
     [not found]                                     ` <20190614023107.GK32656-PfSpb0PWhxZc2C7mugBRk2EX/6BAtgUQ@public.gmane.org>
2019-06-14  3:07                                       ` Dave Chinner
     [not found]                           ` <20190613152755.GI32656-PfSpb0PWhxZc2C7mugBRk2EX/6BAtgUQ@public.gmane.org>
2019-06-20 14:52                             ` Jan Kara
2019-06-13 20:34                         ` Ira Weiny
2019-06-14  2:58                           ` Dave Chinner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190606194652.GI17373@ziepe.ca \
    --to=jgg@ziepe.ca \
    --cc=akpm@linux-foundation.org \
    --cc=dan.j.williams@intel.com \
    --cc=david@fromorbit.com \
    --cc=ira.weiny@intel.com \
    --cc=jack@suse.cz \
    --cc=jglisse@redhat.com \
    --cc=jhubbard@nvidia.com \
    --cc=jlayton@kernel.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-nvdimm@lists.01.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=tytso@mit.edu \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).