From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH v3 hmm 12/12] mm/hmm: Fix error flows in hmm_invalidate_range_start Date: Sat, 15 Jun 2019 07:25:12 -0700 Message-ID: <20190615142512.GL17724@infradead.org> References: <20190614004450.20252-1-jgg@ziepe.ca> <20190614004450.20252-13-jgg@ziepe.ca> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20190614004450.20252-13-jgg-uk2M96/98Pc@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: Jason Gunthorpe Cc: Andrea Arcangeli , Philip Yang , Ralph Campbell , linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, John Hubbard , Felix.Kuehling-5C7GfCeVMHo@public.gmane.org, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, Jerome Glisse , Jason Gunthorpe , amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, Ben Skeggs List-Id: linux-rdma@vger.kernel.org T24gVGh1LCBKdW4gMTMsIDIwMTkgYXQgMDk6NDQ6NTBQTSAtMDMwMCwgSmFzb24gR3VudGhvcnBl IHdyb3RlOgo+IEZyb206IEphc29uIEd1bnRob3JwZSA8amdnQG1lbGxhbm94LmNvbT4KPiAKPiBJ ZiB0aGUgdHJ5bG9jayBvbiB0aGUgaG1tLT5taXJyb3JzX3NlbSBmYWlscyB0aGUgZnVuY3Rpb24g d2lsbCByZXR1cm4KPiB3aXRob3V0IGRlY3JlbWVudGluZyB0aGUgbm90aWZpZXJzIHRoYXQgd2Vy ZSBwcmV2aW91c2x5IGluY3JlbWVudGVkLiBTaW5jZQo+IHRoZSBjYWxsZXIgd2lsbCBub3QgY2Fs bCBpbnZhbGlkYXRlX3JhbmdlX2VuZCgpIG9uIEVBR0FJTiB0aGlzIHdpbGwgcmVzdWx0Cj4gaW4g bm90aWZpZXJzIGJlY29taW5nIHBlcm1hbmVudGx5IGluY3JlbWVudGVkIGFuZCBkZWFkbG9jay4K PiAKPiBJZiB0aGUgc3luY19jcHVfZGV2aWNlX3BhZ2V0YWJsZXMoKSByZXF1aXJlZCBibG9ja2lu ZyB0aGUgZnVuY3Rpb24gd2lsbAo+IG5vdCByZXR1cm4gRUFHQUlOIGV2ZW4gdGhvdWdoIHRoZSBk ZXZpY2UgY29udGludWVzIHRvIHRvdWNoIHRoZQo+IHBhZ2VzLiBUaGlzIGlzIGEgdmlvbGF0aW9u IG9mIHRoZSBtbXUgbm90aWZpZXIgY29udHJhY3QuCj4gCj4gU3dpdGNoLCBhbmQgcmVuYW1lLCB0 aGUgcmFuZ2VzX2xvY2sgdG8gYSBzcGluIGxvY2sgc28gd2UgY2FuIHJlbGlhYmx5Cj4gb2J0YWlu IGl0IHdpdGhvdXQgYmxvY2tpbmcgZHVyaW5nIGVycm9yIHVud2luZC4KPiAKPiBUaGUgZXJyb3Ig dW53aW5kIGlzIG5lY2Vzc2FyeSBzaW5jZSB0aGUgbm90aWZpZXJzIGNvdW50IG11c3QgYmUgaGVs ZAo+IGluY3JlbWVudGVkIGFjcm9zcyB0aGUgY2FsbCB0byBzeW5jX2NwdV9kZXZpY2VfcGFnZXRh YmxlcygpIGFzIHdlIGNhbm5vdAo+IGFsbG93IHRoZSByYW5nZSB0byBiZWNvbWUgbWFya2VkIHZh bGlkIGJ5IGEgcGFyYWxsZWwKPiBpbnZhbGlkYXRlX3N0YXJ0L2VuZCgpIHBhaXIgd2hpbGUgZG9p bmcgc3luY19jcHVfZGV2aWNlX3BhZ2V0YWJsZXMoKS4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBKYXNv biBHdW50aG9ycGUgPGpnZ0BtZWxsYW5veC5jb20+Cj4gUmV2aWV3ZWQtYnk6IFJhbHBoIENhbXBi ZWxsIDxyY2FtcGJlbGxAbnZpZGlhLmNvbT4KPiBUZXN0ZWQtYnk6IFBoaWxpcCBZYW5nIDxQaGls aXAuWWFuZ0BhbWQuY29tPgo+IC0tLQo+ICBpbmNsdWRlL2xpbnV4L2htbS5oIHwgIDIgKy0KPiAg bW0vaG1tLmMgICAgICAgICAgICB8IDc3ICsrKysrKysrKysrKysrKysrKysrKysrKysrKy0tLS0t LS0tLS0tLS0tLS0tLQo+ICAyIGZpbGVzIGNoYW5nZWQsIDQ4IGluc2VydGlvbnMoKyksIDMxIGRl bGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9pbmNsdWRlL2xpbnV4L2htbS5oIGIvaW5jbHVk ZS9saW51eC9obW0uaAo+IGluZGV4IGJmMDEzZTk2NTI1NzcxLi4wZmE4ZWEzNGNjZWY2ZCAxMDA2 NDQKPiAtLS0gYS9pbmNsdWRlL2xpbnV4L2htbS5oCj4gKysrIGIvaW5jbHVkZS9saW51eC9obW0u aAo+IEBAIC04Niw3ICs4Niw3IEBACj4gIHN0cnVjdCBobW0gewo+ICAJc3RydWN0IG1tX3N0cnVj dAkqbW07Cj4gIAlzdHJ1Y3Qga3JlZgkJa3JlZjsKPiAtCXN0cnVjdCBtdXRleAkJbG9jazsKPiAr CXNwaW5sb2NrX3QJCXJhbmdlc19sb2NrOwo+ICAJc3RydWN0IGxpc3RfaGVhZAlyYW5nZXM7Cj4g IAlzdHJ1Y3QgbGlzdF9oZWFkCW1pcnJvcnM7Cj4gIAlzdHJ1Y3QgbW11X25vdGlmaWVyCW1tdV9u b3RpZmllcjsKPiBkaWZmIC0tZ2l0IGEvbW0vaG1tLmMgYi9tbS9obW0uYwo+IGluZGV4IGMwZDQz MzAyZmQ2YjJmLi4xMTcyYTRmMDIwNjk2MyAxMDA2NDQKPiAtLS0gYS9tbS9obW0uYwo+ICsrKyBi L21tL2htbS5jCj4gQEAgLTY3LDcgKzY3LDcgQEAgc3RhdGljIHN0cnVjdCBobW0gKmhtbV9nZXRf b3JfY3JlYXRlKHN0cnVjdCBtbV9zdHJ1Y3QgKm1tKQo+ICAJaW5pdF9yd3NlbSgmaG1tLT5taXJy b3JzX3NlbSk7Cj4gIAlobW0tPm1tdV9ub3RpZmllci5vcHMgPSBOVUxMOwo+ICAJSU5JVF9MSVNU X0hFQUQoJmhtbS0+cmFuZ2VzKTsKPiAtCW11dGV4X2luaXQoJmhtbS0+bG9jayk7Cj4gKwlzcGlu X2xvY2tfaW5pdCgmaG1tLT5yYW5nZXNfbG9jayk7Cj4gIAlrcmVmX2luaXQoJmhtbS0+a3JlZik7 Cj4gIAlobW0tPm5vdGlmaWVycyA9IDA7Cj4gIAlobW0tPm1tID0gbW07Cj4gQEAgLTEyNCwxOCAr MTI0LDE5IEBAIHN0YXRpYyB2b2lkIGhtbV9yZWxlYXNlKHN0cnVjdCBtbXVfbm90aWZpZXIgKm1u LCBzdHJ1Y3QgbW1fc3RydWN0ICptbSkKPiAgewo+ICAJc3RydWN0IGhtbSAqaG1tID0gY29udGFp bmVyX29mKG1uLCBzdHJ1Y3QgaG1tLCBtbXVfbm90aWZpZXIpOwo+ICAJc3RydWN0IGhtbV9taXJy b3IgKm1pcnJvcjsKPiArCXVuc2lnbmVkIGxvbmcgZmxhZ3M7Cj4gIAo+ICAJLyogQmFpbCBvdXQg aWYgaG1tIGlzIGluIHRoZSBwcm9jZXNzIG9mIGJlaW5nIGZyZWVkICovCj4gIAlpZiAoIWtyZWZf Z2V0X3VubGVzc196ZXJvKCZobW0tPmtyZWYpKQo+ICAJCXJldHVybjsKPiAgCj4gLQltdXRleF9s b2NrKCZobW0tPmxvY2spOwo+ICsJc3Bpbl9sb2NrX2lycXNhdmUoJmhtbS0+cmFuZ2VzX2xvY2ss IGZsYWdzKTsKPiAgCS8qCj4gIAkgKiBTaW5jZSBobW1fcmFuZ2VfcmVnaXN0ZXIoKSBob2xkcyB0 aGUgbW1nZXQoKSBsb2NrIGhtbV9yZWxlYXNlKCkgaXMKPiAgCSAqIHByZXZlbnRlZCBhcyBsb25n IGFzIGEgcmFuZ2UgZXhpc3RzLgo+ICAJICovCj4gIAlXQVJOX09OKCFsaXN0X2VtcHR5KCZobW0t PnJhbmdlcykpOwo+IC0JbXV0ZXhfdW5sb2NrKCZobW0tPmxvY2spOwo+ICsJc3Bpbl91bmxvY2tf aXJxcmVzdG9yZSgmaG1tLT5yYW5nZXNfbG9jaywgZmxhZ3MpOwo+ICAKPiAgCWRvd25fcmVhZCgm aG1tLT5taXJyb3JzX3NlbSk7Cj4gIAlsaXN0X2Zvcl9lYWNoX2VudHJ5KG1pcnJvciwgJmhtbS0+ bWlycm9ycywgbGlzdCkgewo+IEBAIC0xNTEsNiArMTUyLDIzIEBAIHN0YXRpYyB2b2lkIGhtbV9y ZWxlYXNlKHN0cnVjdCBtbXVfbm90aWZpZXIgKm1uLCBzdHJ1Y3QgbW1fc3RydWN0ICptbSkKPiAg CWhtbV9wdXQoaG1tKTsKPiAgfQo+ICAKPiArc3RhdGljIHZvaWQgbm90aWZpZXJzX2RlY3JlbWVu dChzdHJ1Y3QgaG1tICpobW0pCj4gK3sKPiArCWxvY2tkZXBfYXNzZXJ0X2hlbGQoJmhtbS0+cmFu Z2VzX2xvY2spOwo+ICsKPiArCWhtbS0+bm90aWZpZXJzLS07Cj4gKwlpZiAoIWhtbS0+bm90aWZp ZXJzKSB7CgpOaXRwaWNrLCB3aGVuIGRvaW5nIGRlYyBhbmQgdGVzdCBvciBpbmMgYW5kIHRlc3Qg b3BzIEkgZmluZCBpdCBtdWNoCmVhc2llciB0byByZWFkIGlmIHRoZXkgYXJlIG1lcmdlZCBpbnRv IG9uZSBsaW5lLCBpLmUuCgoJaWYgKCEtLWhtbS0+bm90aWZpZXJzKSB7CgpPdGhlcndpc2UgdGhp cyBsb29rcyBmaW5lOgoKUmV2aWV3ZWQtYnk6IENocmlzdG9waCBIZWxsd2lnIDxoY2hAbHN0LmRl PgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwphbWQtZ2Z4 IG1haWxpbmcgbGlzdAphbWQtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3Rz LmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2FtZC1nZng=