From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leon Romanovsky Subject: Re: [PATCH mlx5-next 11/15] RDMA/mlx5: Add vport metadata matching for IB representors Date: Wed, 19 Jun 2019 05:04:15 +0000 Message-ID: <20190619050412.GC11611@mtr-leonro.mtl.com> References: <20190617192247.25107-1-saeedm@mellanox.com> <20190617192247.25107-12-saeedm@mellanox.com> <20190618101928.GE4690@mtr-leonro.mtl.com> <20190619044420.GA30694@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <20190619044420.GA30694@mellanox.com> Content-Language: en-US Content-ID: <2E6DD96A77ED9B44865F646136E65DA9@eurprd05.prod.outlook.com> Sender: netdev-owner@vger.kernel.org To: Jianbo Liu Cc: Saeed Mahameed , "netdev@vger.kernel.org" , "linux-rdma@vger.kernel.org" , Roi Dayan , Mark Bloch List-Id: linux-rdma@vger.kernel.org On Wed, Jun 19, 2019 at 04:44:26AM +0000, Jianbo Liu wrote: > The 06/18/2019 18:19, Leon Romanovsky wrote: > > On Mon, Jun 17, 2019 at 07:23:30PM +0000, Saeed Mahameed wrote: > > > From: Jianbo Liu > > > > > > If vport metadata matching is enabled in eswitch, the rule created > > > must be changed to match on the metadata, instead of source port. > > > > > > Signed-off-by: Jianbo Liu > > > Reviewed-by: Roi Dayan > > > Reviewed-by: Mark Bloch > > > Signed-off-by: Saeed Mahameed > > > --- > > > drivers/infiniband/hw/mlx5/ib_rep.c | 11 +++++++ > > > drivers/infiniband/hw/mlx5/ib_rep.h | 16 ++++++++++ > > > drivers/infiniband/hw/mlx5/main.c | 45 +++++++++++++++++++++++----= -- > > > 3 files changed, 63 insertions(+), 9 deletions(-) > > > > > > diff --git a/drivers/infiniband/hw/mlx5/ib_rep.c b/drivers/infiniband= /hw/mlx5/ib_rep.c > > > index 22e651cb5534..d4ed611de35d 100644 > > > --- a/drivers/infiniband/hw/mlx5/ib_rep.c > > > +++ b/drivers/infiniband/hw/mlx5/ib_rep.c > > > @@ -131,6 +131,17 @@ struct mlx5_eswitch_rep *mlx5_ib_vport_rep(struc= t mlx5_eswitch *esw, int vport) > > > return mlx5_eswitch_vport_rep(esw, vport); > > > } > > > > > > +u32 mlx5_ib_eswitch_vport_match_metadata_enabled(struct mlx5_eswitch= *esw) > > > +{ > > > + return mlx5_eswitch_vport_match_metadata_enabled(esw); > > > +} > > > + > > > +u32 mlx5_ib_eswitch_get_vport_metadata_for_match(struct mlx5_eswitch= *esw, > > > + u16 vport) > > > +{ > > > + return mlx5_eswitch_get_vport_metadata_for_match(esw, vport); > > > +} > > > > 1. There is no need to introduce one line functions, call to that code = directly. > > No. They are in IB, and we don't want them be mixed up by the original > functions in eswitch. Please ask Mark more about it. Please enlighten me. > > > 2. It should be bool and not u32. > > > > Thanks > > --