Re: [RFC PATCH 00/28] Removing struct page from P2PDMA

Christoph Hellwig
2019-06-25T07:18:23Z

On Mon, Jun 24, 2019 at 10:10:16AM -0600, Logan Gunthorpe wrote:
> Yes, that's correct. The intent was to invert it so the dma_map could
> happen at the start of the process so that P2PDMA code could be called
> with all the information it needs to make it's decision on how to map;
> without having to hook into the mapping process of every driver that
> wants to participate.

And that just isn't how things work in layering. We need to keep
generating the dma addresses in the driver in the receiving end, as
there are all kinds of interesting ideas how we do that. E.g. for the
Mellanox NICs addressing their own bars is not done by PCIe bus
addresses but by relative offsets. And while NVMe has refused to go
down that route in the current band aid fix for CMB addressing I suspect
it will sooner or later have to do the same to deal with the addressing
problems in a multiple PASID world.