From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51F07C06513 for ; Thu, 4 Jul 2019 12:29:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1A4092189E for ; Thu, 4 Jul 2019 12:29:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1562243396; bh=cCA734VwPTICEaI1cmL5+rdDiipXZEg0/8PoB29Wtek=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=FGY1kbXqZGSRkMGvcSQZfUuD9dCPlh7ogDPbPMID/bCyRyXUbxUrx8I2pZ+prNuSq /L/XevGIGnScqVOsvnzKHzyqzyQcSiTvxqohK3U0Q1fsFz5q0ObYnTdgp8vlf6NeR5 RqbGf+YqlmiS8JmBpTeaqgJ7B9vgXviqvPx4t34w= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727632AbfGDM3z (ORCPT ); Thu, 4 Jul 2019 08:29:55 -0400 Received: from mail.kernel.org ([198.145.29.99]:44496 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727602AbfGDM3z (ORCPT ); Thu, 4 Jul 2019 08:29:55 -0400 Received: from localhost (unknown [89.205.128.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1CFDB20673; Thu, 4 Jul 2019 12:29:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1562243394; bh=cCA734VwPTICEaI1cmL5+rdDiipXZEg0/8PoB29Wtek=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BW/VwhEpy7xItdMoud2x9A4L/D196EuzHEmR+FKfdvcBeJ7dzqgt9VqXNte3QlywX WS5PjUxkXsaRB1WqshDoTW1tmwj30TFxVWVqYH8nT0xBYHTYeb0FU1tGy3pCl7SmvF sgvJZRPmww3SZqknHO/eV8IYduPV1nQifV7nmW7w= Date: Thu, 4 Jul 2019 14:29:50 +0200 From: Greg KH To: Jason Gunthorpe Cc: Jeff Kirsher , "davem@davemloft.net" , "dledford@redhat.com" , Tony Nguyen , "netdev@vger.kernel.org" , "linux-rdma@vger.kernel.org" , "nhorman@redhat.com" , "sassmann@redhat.com" , "poswald@suse.com" , "mustafa.ismail@intel.com" , "shiraz.saleem@intel.com" , Dave Ertman , Andrew Bowers Subject: Re: [net-next 1/3] ice: Initialize and register platform device to provide RDMA Message-ID: <20190704122950.GA6007@kroah.com> References: <20190704021252.15534-1-jeffrey.t.kirsher@intel.com> <20190704021252.15534-2-jeffrey.t.kirsher@intel.com> <20190704121632.GB3401@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190704121632.GB3401@mellanox.com> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Thu, Jul 04, 2019 at 12:16:41PM +0000, Jason Gunthorpe wrote: > On Wed, Jul 03, 2019 at 07:12:50PM -0700, Jeff Kirsher wrote: > > From: Tony Nguyen > > > > The RDMA block does not advertise on the PCI bus or any other bus. > > Thus the ice driver needs to provide access to the RDMA hardware block > > via a virtual bus; utilize the platform bus to provide this access. > > > > This patch initializes the driver to support RDMA as well as creates > > and registers a platform device for the RDMA driver to register to. At > > this point the driver is fully initialized to register a platform > > driver, however, can not yet register as the ops have not been > > implemented. > > I think you need Greg's ack on all this driver stuff - particularly > that a platform_device is OK. A platform_device is almost NEVER ok. Don't abuse it, make a real device on a real bus. If you don't have a real bus and just need to create a device to hang other things off of, then use the virtual one, that's what it is there for. thanks, greg k-h