From: Jason Gunthorpe <jgg@ziepe.ca>
To: Leon Romanovsky <leon@kernel.org>
Cc: Doug Ledford <dledford@redhat.com>,
Valentine Fatiev <valentinef@mellanox.com>,
RDMA mailing list <linux-rdma@vger.kernel.org>,
Feras Daoud <ferasda@mellanox.com>,
Leon Romanovsky <leonro@mellanox.com>
Subject: Re: [PATCH rdma-next] IB/ipoib: Add child to parent list only if device initialized
Date: Thu, 4 Jul 2019 14:30:10 -0300 [thread overview]
Message-ID: <20190704173010.GA16955@ziepe.ca> (raw)
In-Reply-To: <20190630134841.19413-1-leon@kernel.org>
On Sun, Jun 30, 2019 at 04:48:41PM +0300, Leon Romanovsky wrote:
> From: Valentine Fatiev <valentinef@mellanox.com>
>
> Despite failure in ipoib_dev_init() we continue with initialization
> flow and creation of child device. It causes to the situation
> where this child device is added too early to parent device list.
>
> change the logic, so in case of failure we properly return error
> from ipoib_dev_init() and add child only in success path.
>
> Fixes: eaeb39842508 ("IB/ipoib: Move init code to ndo_init")
> Signed-off-by: Valentine Fatiev <valentinef@mellanox.com>
> Reviewed-by: Feras Daoud <ferasda@mellanox.com>
> Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
> ---
> drivers/infiniband/ulp/ipoib/ipoib_main.c | 34 +++++++++++++----------
> 1 file changed, 20 insertions(+), 14 deletions(-)
Applied to for-next, thanks
Jason
parent reply other threads:[~2019-07-04 17:30 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20190630134841.19413-1-leon@kernel.org>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190704173010.GA16955@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=dledford@redhat.com \
--cc=ferasda@mellanox.com \
--cc=leon@kernel.org \
--cc=leonro@mellanox.com \
--cc=linux-rdma@vger.kernel.org \
--cc=valentinef@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox