From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFFF0C46499 for ; Fri, 5 Jul 2019 17:44:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BED3C2089C for ; Fri, 5 Jul 2019 17:44:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="OEh7mxFJ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725778AbfGERon (ORCPT ); Fri, 5 Jul 2019 13:44:43 -0400 Received: from mail-qk1-f195.google.com ([209.85.222.195]:33805 "EHLO mail-qk1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725681AbfGERom (ORCPT ); Fri, 5 Jul 2019 13:44:42 -0400 Received: by mail-qk1-f195.google.com with SMTP id t8so8484483qkt.1 for ; Fri, 05 Jul 2019 10:44:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=DsDN0H5pNL1/ICNH7Dz5V8XSb6ubjK0QwX5N9406DZY=; b=OEh7mxFJXRNgAyctuFs8gk6m1I9rirSLGW1FIcEelBtOTuh+ULSX/GZT8vIMowNJKw JQL1fcimYpTfNtI69npHD9xUw8e2nR31uGDZz1lgB2kUReUpu5/8VWdc0f0NrOpv5p5F MC82xPU+MaPFHg8tslLM2GVk0rHSlUnd4TpGlMyZt8E6PVTToKPZg7DUCYbshESbUDyz 1/+AA0QVQv/wjSw5Gwvctr89DlzLSvl7boalJk4sPr0HoRskXWfRUs136DB7n4l2HbPl Ir/oQOQSafxGIh5vEXn9aKGt0NsP7PaN5Y/qhdtk7ptBKkhYi07AgKrhqwPh+cJ/vtTV VXvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=DsDN0H5pNL1/ICNH7Dz5V8XSb6ubjK0QwX5N9406DZY=; b=FrOCHkEx8VFGo3YTTI2RnkLehR/CkJi3LkjFpLPJXt0zJZB9tBRkxj25tPzovX91Ed z8SerMVcvmDggZnZOWbVALbIY5o+415w0+UsZp1/yVbs3WJ4xWCt+8Nvw7U2+G5tANnk XvIpYcy1daKsgWuHKCvYO7YVErcLEpZwAE8qatJ9xtdSmFdLDo6rdRYbuLCeINQY9OFf eLoVcqXtmaJX7ZADwUWFxIGk2OoDFTbuKCjwTY2esNTM5M6RpPlPBPAjiF1+gvHhVY8h gXgBIaKzTzd5OZSB09hU0U0AQz1gNaP+s0WDYL0PUh/Bpl3+WGfmsx3huSJDrMl2Gm9K n2lA== X-Gm-Message-State: APjAAAVOI5UMQpzPg26iiSRwmI3JUV0BlpUJ8P7+3WqdXgWFquiKsnmC LlmkoNTdo3vMO87ucfy3FCB+4Ub+pnweWw== X-Google-Smtp-Source: APXvYqwGZsX1qLiJR25nWBEJF111+YGImEO01o8cQDZMyEbtN4amyyfQT/a8/7yHrXJIASfk8B/3cw== X-Received: by 2002:a37:aa06:: with SMTP id t6mr4166621qke.226.1562348681740; Fri, 05 Jul 2019 10:44:41 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-156-34-55-100.dhcp-dynamic.fibreop.ns.bellaliant.net. [156.34.55.100]) by smtp.gmail.com with ESMTPSA id c74sm875552qke.128.2019.07.05.10.44.41 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 05 Jul 2019 10:44:41 -0700 (PDT) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1hjSGG-0003oI-Tj; Fri, 05 Jul 2019 14:44:40 -0300 Date: Fri, 5 Jul 2019 14:44:40 -0300 From: Jason Gunthorpe To: Maksym Planeta Cc: Moni Shoua , Doug Ledford , linux-rdma@vger.kernel.org Subject: Re: [PATCH] ibverbs/rxe: Remove variable self-initialization Message-ID: <20190705174440.GA14622@ziepe.ca> References: <20190702134928.31534-1-mplaneta@os.inf.tu-dresden.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190702134928.31534-1-mplaneta@os.inf.tu-dresden.de> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Tue, Jul 02, 2019 at 03:49:28PM +0200, Maksym Planeta wrote: > In some cases (not in this particular one) variable self-initialization > can lead to undefined behavior. In this case, it is just obscure code. > > Signed-off-by: Maksym Planeta > --- > drivers/infiniband/sw/rxe/rxe_comp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied to for-next, thanks Jason