Linux RDMA and InfiniBand development
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgg@mellanox.com>
To: Leon Romanovsky <leon@kernel.org>
Cc: Doug Ledford <dledford@redhat.com>,
	Danit Goldberg <danitg@mellanox.com>,
	RDMA mailing list <linux-rdma@vger.kernel.org>,
	Artemy Kovalyov <artemyko@mellanox.com>,
	Yishai Hadas <yishaih@mellanox.com>
Subject: Re: [PATCH rdma-next] IB/mlx5: Report correctly tag matching rendezvous capability
Date: Mon, 8 Jul 2019 17:26:25 +0000	[thread overview]
Message-ID: <20190708172622.GK23966@mellanox.com> (raw)
In-Reply-To: <20190706163523.GA18182@mtr-leonro.mtl.com>

On Sat, Jul 06, 2019 at 07:35:23PM +0300, Leon Romanovsky wrote:
> > > diff --git a/include/rdma/ib_verbs.h b/include/rdma/ib_verbs.h
> > > index 30eb68f36109..c5f8a9f17063 100644
> > > +++ b/include/rdma/ib_verbs.h
> > > @@ -308,8 +308,8 @@ struct ib_rss_caps {
> > >  };
> > >
> > >  enum ib_tm_cap_flags {
> > > -	/*  Support tag matching on RC transport */
> > > -	IB_TM_CAP_RC		    = 1 << 0,
> > > +	/*  Support tag matching with rendezvous offload for RC transport */
> > > +	IB_TM_CAP_RNDV_RC = 1 << 0,
> > >  };
> >
> > This is in the wrong header, right?
> 
> It predates our all-to-uapi headers approach and moving to UAPI this struct
> is definitely too much for a fix which should go to stable@.

Well, lets send a patch to fix it please

Jason

  reply	other threads:[~2019-07-08 17:26 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-05 16:21 [PATCH rdma-next] IB/mlx5: Report correctly tag matching rendezvous capability Leon Romanovsky
2019-07-05 17:15 ` Jason Gunthorpe
2019-07-06 16:35   ` Leon Romanovsky
2019-07-08 17:26     ` Jason Gunthorpe [this message]
2019-07-08 17:39 ` Jason Gunthorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190708172622.GK23966@mellanox.com \
    --to=jgg@mellanox.com \
    --cc=artemyko@mellanox.com \
    --cc=danitg@mellanox.com \
    --cc=dledford@redhat.com \
    --cc=leon@kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=yishaih@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox