public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgg@ziepe.ca>
To: Leon Romanovsky <leon@kernel.org>
Cc: Doug Ledford <dledford@redhat.com>,
	Leon Romanovsky <leonro@mellanox.com>,
	RDMA mailing list <linux-rdma@vger.kernel.org>,
	Parav Pandit <parav@mellanox.com>,
	Steve Wise <swise@opengridcomputing.com>
Subject: Re: [PATCH rdma-next 2/2] IB: Support netlink commands in non init_net net namespaces
Date: Mon, 8 Jul 2019 17:20:23 -0300	[thread overview]
Message-ID: <20190708202023.GA8020@ziepe.ca> (raw)
In-Reply-To: <20190704130402.8431-3-leon@kernel.org>

On Thu, Jul 04, 2019 at 04:04:02PM +0300, Leon Romanovsky wrote:
> -int rdma_nl_unicast(struct sk_buff *skb, u32 pid)
> +int rdma_nl_unicast(struct net *net, struct sk_buff *skb, u32 pid)
>  {
> +	struct rdma_dev_net *rnet = net_generic(net, rdma_dev_net_id);

This should be a proper type safe accessor in all places

> -void rdma_nl_exit(void)
> +void rdma_nl_net_exit(struct rdma_dev_net *rnet)
>  {
> -	int idx;
> -
> -	for (idx = 0; idx < RDMA_NL_NUM_CLIENTS; idx++)
> -		rdma_nl_unregister(idx);

There should be a WARN_ON during the module unload that no NL clients
are still registered

Thanks,
Jason

  reply	other threads:[~2019-07-08 20:20 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-04 13:04 [PATCH rdma-next 0/2] Allow netlink commands in non init_net net namespace Leon Romanovsky
2019-07-04 13:04 ` [PATCH rdma-next 1/2] IB/core: Work on the caller socket net namespace in nldev_newlink() Leon Romanovsky
2019-07-04 13:04 ` [PATCH rdma-next 2/2] IB: Support netlink commands in non init_net net namespaces Leon Romanovsky
2019-07-08 20:20   ` Jason Gunthorpe [this message]
2019-07-09  6:38     ` Leon Romanovsky
2019-07-09 12:25       ` Jason Gunthorpe
2019-07-09  6:55     ` Parav Pandit
2019-07-04 17:34 ` [PATCH rdma-next 0/2] Allow netlink commands in non init_net net namespace Jason Gunthorpe
2019-07-05  2:12   ` Parav Pandit
2019-07-08 20:21 ` Jason Gunthorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190708202023.GA8020@ziepe.ca \
    --to=jgg@ziepe.ca \
    --cc=dledford@redhat.com \
    --cc=leon@kernel.org \
    --cc=leonro@mellanox.com \
    --cc=linux-rdma@vger.kernel.org \
    --cc=parav@mellanox.com \
    --cc=swise@opengridcomputing.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox