From: Nathan Chancellor <natechancellor@gmail.com>
To: Nick Desaulniers <ndesaulniers@google.com>
Cc: Jason Gunthorpe <jgg@ziepe.ca>,
Bernard Metzler <bmt@zurich.ibm.com>,
Doug Ledford <dledford@redhat.com>,
linux-rdma@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
clang-built-linux <clang-built-linux@googlegroups.com>
Subject: Re: [PATCH] rdma/siw: Use proper enumerated type in map_cqe_status
Date: Wed, 10 Jul 2019 20:02:35 -0700 [thread overview]
Message-ID: <20190711030235.GA12012@archlinux-threadripper> (raw)
In-Reply-To: <CAKwvOd=yJQgzjQBKW7=en_YnF6OCAg0MXy5c6c9tBLSjGgorPA@mail.gmail.com>
On Wed, Jul 10, 2019 at 04:53:50PM -0700, Nick Desaulniers wrote:
> On Wed, Jul 10, 2019 at 11:26 AM Jason Gunthorpe <jgg@ziepe.ca> wrote:
> >
> > On Wed, Jul 10, 2019 at 10:48:00AM -0700, Nathan Chancellor wrote:
> > > clang warns several times:
> > >
> > > drivers/infiniband/sw/siw/siw_cq.c:31:4: warning: implicit conversion
> > > from enumeration type 'enum siw_wc_status' to different enumeration type
> > > 'enum siw_opcode' [-Wenum-conversion]
> > Weird that gcc doesn't warn on this by default..
>
> Based on the sheer number of -Wenum-conversion that Nathan has fixed,
> I don't think gcc has -Wenum-conversion (or it's somehow disabled just
> for gcc).
> --
> Thanks,
> ~Nick Desaulniers
Yes, as far as I am aware, GCC does not warn on implicit enum
conversions (which I think defeats the purpose of enumerated types
*shrugs*).
Cheers,
Nathan
next prev parent reply other threads:[~2019-07-11 3:02 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-10 17:48 [PATCH] rdma/siw: Use proper enumerated type in map_cqe_status Nathan Chancellor
2019-07-10 18:26 ` Jason Gunthorpe
2019-07-10 23:53 ` Nick Desaulniers
2019-07-11 3:02 ` Nathan Chancellor [this message]
2019-07-11 7:44 ` Bernard Metzler
2019-07-11 8:14 ` Nathan Chancellor
2019-07-11 13:39 ` Jason Gunthorpe
2019-07-11 17:16 ` Nick Desaulniers
2019-07-11 17:18 ` Jason Gunthorpe
2019-07-11 17:30 ` Nathan Chancellor
2019-08-23 14:24 ` Jason Gunthorpe
2019-08-26 15:38 ` Nathan Chancellor
2019-08-26 15:42 ` Jason Gunthorpe
2019-08-26 23:38 ` Nathan Chancellor
2019-08-27 15:08 ` Josh Poimboeuf
2019-08-27 17:00 ` Leon Romanovsky
2019-08-27 19:23 ` Josh Poimboeuf
2019-08-27 21:27 ` Nick Desaulniers
2019-08-27 22:50 ` Nick Desaulniers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190711030235.GA12012@archlinux-threadripper \
--to=natechancellor@gmail.com \
--cc=bmt@zurich.ibm.com \
--cc=clang-built-linux@googlegroups.com \
--cc=dledford@redhat.com \
--cc=jgg@ziepe.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=ndesaulniers@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).