From: Nathan Chancellor <natechancellor@gmail.com>
To: Bernard Metzler <BMT@zurich.ibm.com>
Cc: Doug Ledford <dledford@redhat.com>,
Jason Gunthorpe <jgg@ziepe.ca>,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
clang-built-linux@googlegroups.com
Subject: Re: [PATCH] rdma/siw: Use proper enumerated type in map_cqe_status
Date: Thu, 11 Jul 2019 01:14:34 -0700 [thread overview]
Message-ID: <20190711081434.GA86557@archlinux-threadripper> (raw)
In-Reply-To: <OFE93E0F86.E35CE856-ON00258434.002A83CE-00258434.002A83DF@notes.na.collabserv.com>
Hi Bernard,
On Thu, Jul 11, 2019 at 07:44:22AM +0000, Bernard Metzler wrote:
> Nathan, thanks very much. That's correct.
Thanks for the confirmation that the fix was correct.
> I don't know how this could pass w/o warning.
Unfortunately, it appears that GCC only warns when two different
enumerated types are directly compared, not when they are implicitly
converted between.
https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wenum-compare
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78736
If it did, I wouldn't have fixed as many warnings as I have.
https://github.com/ClangBuiltLinux/linux/issues?q=is%3Aissue+is%3Aclosed+label%3A-Wenum-conversion
Maybe time to start plumbing Clang into your test flow until it can get
intergrated with more CI setups? :) It can catch some pretty dodgy
behavior that GCC doesn't:
https://github.com/ClangBuiltLinux/linux/issues/390
https://github.com/ClangBuiltLinux/linux/issues/544
Kernel CI has added support for it (although they don't email the
authors of patches individually) and 0day is currently working on it.
Feel free to reach out if you decide to explore it, I'm always happy
to help.
Cheers,
Nathan
next prev parent reply other threads:[~2019-07-11 8:14 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-10 17:48 [PATCH] rdma/siw: Use proper enumerated type in map_cqe_status Nathan Chancellor
2019-07-10 18:26 ` Jason Gunthorpe
2019-07-10 23:53 ` Nick Desaulniers
2019-07-11 3:02 ` Nathan Chancellor
2019-07-11 7:44 ` Bernard Metzler
2019-07-11 8:14 ` Nathan Chancellor [this message]
2019-07-11 13:39 ` Jason Gunthorpe
2019-07-11 17:16 ` Nick Desaulniers
2019-07-11 17:18 ` Jason Gunthorpe
2019-07-11 17:30 ` Nathan Chancellor
2019-08-23 14:24 ` Jason Gunthorpe
2019-08-26 15:38 ` Nathan Chancellor
2019-08-26 15:42 ` Jason Gunthorpe
2019-08-26 23:38 ` Nathan Chancellor
2019-08-27 15:08 ` Josh Poimboeuf
2019-08-27 17:00 ` Leon Romanovsky
2019-08-27 19:23 ` Josh Poimboeuf
2019-08-27 21:27 ` Nick Desaulniers
2019-08-27 22:50 ` Nick Desaulniers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190711081434.GA86557@archlinux-threadripper \
--to=natechancellor@gmail.com \
--cc=BMT@zurich.ibm.com \
--cc=clang-built-linux@googlegroups.com \
--cc=dledford@redhat.com \
--cc=jgg@ziepe.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).