From: Jason Gunthorpe <jgg@ziepe.ca>
To: Qian Cai <cai@lca.pw>
Cc: leonro@mellanox.com, saeedm@mellanox.com, talgi@mellanox.com,
yaminf@mellanox.com, linux-rdma@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] RDMA/core: fix -Wunused-const-variable warnings
Date: Thu, 11 Jul 2019 11:54:04 -0300 [thread overview]
Message-ID: <20190711145404.GA23576@ziepe.ca> (raw)
In-Reply-To: <1562853356-11595-1-git-send-email-cai@lca.pw>
On Thu, Jul 11, 2019 at 09:55:56AM -0400, Qian Cai wrote:
> The linux-next commit "linux/dim: Implement RDMA adaptive moderation
> (DIM)" [1] introduced a few compilation warnings.
>
> In file included from ./include/rdma/ib_verbs.h:64,
> from ./include/linux/mlx5/device.h:37,
> from ./include/linux/mlx5/driver.h:51,
> from drivers/net/ethernet/mellanox/mlx5/core/uar.c:36:
> ./include/linux/dim.h:378:1: warning: 'rdma_dim_prof' defined but not
> used [-Wunused-const-variable=]
> rdma_dim_prof[RDMA_DIM_PARAMS_NUM_PROFILES] = {
> ^~~~~~~~~~~~~
> In file included from ./include/rdma/ib_verbs.h:64,
> from ./include/linux/mlx5/device.h:37,
> from ./include/linux/mlx5/driver.h:51,
> from
> drivers/net/ethernet/mellanox/mlx5/core/pagealloc.c:37:
> ./include/linux/dim.h:378:1: warning: 'rdma_dim_prof' defined but not
> used [-Wunused-const-variable=]
> rdma_dim_prof[RDMA_DIM_PARAMS_NUM_PROFILES] = {
> ^~~~~~~~~~~~~
>
> Since only ib_cq_rdma_dim_work() in drivers/infiniband/core/cq.c uses
> it, just move the definition over there.
>
> [1] https://patchwork.kernel.org/patch/11031455/
>
> Signed-off-by: Qian Cai <cai@lca.pw>
> ---
> drivers/infiniband/core/cq.c | 13 +++++++++++++
> include/linux/dim.h | 13 -------------
> 2 files changed, 13 insertions(+), 13 deletions(-)
Applied to for-next, thanks
Jason
prev parent reply other threads:[~2019-07-11 14:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-11 13:55 [PATCH -next] RDMA/core: fix -Wunused-const-variable warnings Qian Cai
2019-07-11 14:54 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190711145404.GA23576@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=cai@lca.pw \
--cc=leonro@mellanox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=saeedm@mellanox.com \
--cc=talgi@mellanox.com \
--cc=yaminf@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox